Make minion task metadata manager methods more generic #9436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Codecov Report
@@ Coverage Diff @@
## master #9436 +/- ##
============================================
- Coverage 69.82% 61.28% -8.54%
+ Complexity 5095 4563 -532
============================================
Files 1889 1877 -12
Lines 100851 100497 -354
Branches 15328 15290 -38
============================================
- Hits 70421 61593 -8828
- Misses 25453 34236 +8783
+ Partials 4977 4668 -309
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
saurabhd336
force-pushed
the
minionTaskMetadataGeneric
branch
from
2d9b15f to
0de0e0b
Compare
klsince
approved these changes
Sep 20, 2022
zhtaoxiang
approved these changes
Sep 20, 2022
61yao
pushed a commit
to 61yao/pinot
that referenced
this pull request
Oct 3, 2022
Co-authored-by: Saurabh Dubey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes minion task metadata manager methods generic so they can work for other task types too