Optimize combine operator to fully utilize threads #9387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Good one. |
Codecov Report
@@ Coverage Diff @@
## master #9387 +/- ##
=============================================
- Coverage 69.75% 35.08% -34.68%
+ Complexity 5095 185 -4910
=============================================
Files 1885 1885
Lines 100406 100411 +5
Branches 15277 15277
=============================================
- Hits 70042 35227 -34815
- Misses 25414 62178 +36764
+ Partials 4950 3006 -1944
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
|
LGTM |
siddharthteotia
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in the combine operator all the segments are pre-assigned to the threads. If one thread finishes early, it won't be able to pick up more segments.
This PR makes the threads pick up segments once the previous one is finished