Allow expression transformer cotinue on error #9376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayankshriv
approved these changes
Sep 11, 2022
xiangfu0
requested review from
Jackie-Jiang,
KKcorps,
kishoreg,
mayankshriv and
npawar
xiangfu0
force-pushed
the
all_expression_transformer_continue_on_error
branch
from
abaf680 to
d459875
Compare
Codecov Report
@@ Coverage Diff @@
## master #9376 +/- ##
============================================
+ Coverage 69.77% 69.80% +0.03%
- Complexity 4783 5080 +297
============================================
Files 1885 1885
Lines 100288 100293 +5
Branches 15254 15256 +2
============================================
+ Hits 69974 70009 +35
+ Misses 25362 25335 -27
+ Partials 4952 4949 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| try { | ||
| record.putValue(column, transformFunctionEvaluator.evaluate(record)); | ||
| } catch (Exception e) { | ||
| record.putValue(column, null); |
Contributor
There was a problem hiding this comment.
This putValue() is redundant. Also we should consider logging something (similar to DataTypeTransformer)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let expression transformer also honor continueOnError flag.