skip late cron job with max allowed delay #9372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klsince
force-pushed
the
skip_late_cron_job
branch
from
557a474 to
95a1187
Compare
Jackie-Jiang
added
release-notes
Jackie-Jiang
approved these changes
Sep 9, 2022
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java
Outdated
Show resolved
Hide resolved
klsince
force-pushed
the
skip_late_cron_job
branch
from
95a1187 to
7cce0f6
Compare
Codecov Report
@@ Coverage Diff @@
## master #9372 +/- ##
============================================
+ Coverage 69.75% 69.80% +0.05%
- Complexity 4707 4785 +78
============================================
Files 1884 1884
Lines 100273 100296 +23
Branches 15252 15254 +2
============================================
+ Hits 69942 70014 +72
+ Misses 25380 25336 -44
+ Partials 4951 4946 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a feature flag to allow to skip late cron schedules to shed load from the cron scheduler. Otherwise the scheduler would lag behind further and further, and one has to restart controller to shed all schedules and catch up.
Release note