Skip to content

[DO NOT MERGE][Benchmark] And evaluation enhancement benchmark with BufferFastAggregation.and #9370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jasperjiaguo wants to merge 17 commits into from
Closed

[DO NOT MERGE][Benchmark] And evaluation enhancement benchmark with BufferFastAggregation.and #9370

jasperjiaguo wants to merge 17 commits into from

Conversation

@jasperjiaguo
Copy link
Contributor

@jasperjiaguo jasperjiaguo commented Sep 9, 2022

see #9336

@jasperjiaguo jasperjiaguo mentioned this pull request Sep 9, 2022
Merged
@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2022 •
edited
Loading

Codecov Report

Merging #9370 (9d8b653) into master (0f4bcfc) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #9370      +/-   ##
============================================
- Coverage     69.80%   69.76%   -0.04%     
- Complexity     4777     5078     +301     
============================================
  Files          1875     1884       +9     
  Lines         99860   100283     +423     
  Branches      15194    15253      +59     
============================================
+ Hits          69706    69965     +259     
- Misses        25231    25370     +139     
- Partials       4923     4948      +25
Flag Coverage Δ
integration1 26.13% <20.00%> (-0.07%) ⬇️
integration2 24.73% <100.00%> (-0.26%) ⬇️
unittests1 66.93% <100.00%> (-0.16%) ⬇️
unittests2 15.31% <0.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...che/pinot/core/operator/docidsets/AndDocIdSet.java 100.00% <100.00%> (ø)
...g/apache/pinot/server/api/resources/ErrorInfo.java 0.00% <0.00%> (-100.00%) ⬇️
...t/server/api/resources/DefaultExceptionMapper.java 0.00% <0.00%> (-75.00%) ⬇️
...erator/blocks/results/AggregationResultsBlock.java 72.15% <0.00%> (-23.60%) ⬇️
...aggregation/function/AggregationFunctionUtils.java 71.11% <0.00%> (-18.89%) ⬇️
...cheduler/resources/PolicyBasedResourceManager.java 75.00% <0.00%> (-18.75%) ⬇️
.../predicate/NotEqualsPredicateEvaluatorFactory.java 66.34% <0.00%> (-13.47%) ⬇️
.../pinot/query/runtime/utils/ServerRequestUtils.java 80.35% <0.00%> (-13.40%) ⬇️
...ient/JsonAsyncHttpPinotClientTransportFactory.java 68.75% <0.00%> (-12.02%) ⬇️
...ore/query/scheduler/resources/ResourceManager.java 84.00% <0.00%> (-12.00%) ⬇️
... and 86 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jasperjiaguo jasperjiaguo force-pushed the and_evaluation_enhancement_2 branch from a004723 to 66cc584 Compare September 9, 2022 23:06
@jasperjiaguo jasperjiaguo changed the title [DO NOT MERGE] And evaluation enhancement benchmark with BufferFastAggregation.and [DO NOT MERGE][Benchmark] And evaluation enhancement benchmark with BufferFastAggregation.and Sep 9, 2022
@jasperjiaguo jasperjiaguo force-pushed the and_evaluation_enhancement_2 branch from 66cc584 to 1de8213 Compare September 10, 2022 00:11
@jasperjiaguo jasperjiaguo force-pushed the and_evaluation_enhancement_2 branch from 1de8213 to 9d8b653 Compare September 10, 2022 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardstartin richardstartin richardstartin left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jasperjiaguo @codecov-commenter @richardstartin