Improve segment name check in metadata push #9359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackie-Jiang
reviewed
Sep 9, 2022
...egment-spi/src/main/java/org/apache/pinot/segment/spi/creator/name/SegmentNameGenerator.java
Outdated
Show resolved
Hide resolved
Jackie-Jiang
approved these changes
Sep 9, 2022
Codecov Report
@@ Coverage Diff @@
## master #9359 +/- ##
============================================
- Coverage 69.75% 68.50% -1.25%
- Complexity 4707 4778 +71
============================================
Files 1884 1885 +1
Lines 100273 100283 +10
Branches 15252 15254 +2
============================================
- Hits 69942 68696 -1246
- Misses 25380 26655 +1275
+ Partials 4951 4932 -19
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
KKcorps
approved these changes
Sep 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve segment name check in metadata push:
1/ we can now push segments stored in Pinot deep store (owned by other tables)
2/ validate the segment name