Skip to content

Conversation

@61yao
Copy link
Contributor

@61yao 61yao commented Sep 6, 2022

Not scalar function for post-aggregate not.
This function takes a boolean and returns logical negate of the param.

@codecov-commenter
Copy link

Codecov Report

Merging #9338 (8c82c4d) into master (2f19683) will decrease coverage by 45.02%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master    #9338       +/-   ##
=============================================
- Coverage     69.88%   24.85%   -45.03%     
+ Complexity     5008       53     -4955     
=============================================
  Files          1854     1864       +10     
  Lines         98871    99508      +637     
  Branches      15043    15156      +113     
=============================================
- Hits          69094    24732    -44362     
- Misses        24904    72275    +47371     
+ Partials       4873     2501     -2372     
Flag Coverage Δ
integration1 ?
integration2 24.85% <0.00%> (+0.11%) ⬆️
unittests1 ?
unittests2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...pinot/common/function/scalar/LogicalFunctions.java 0.00% <0.00%> (ø)
...in/java/org/apache/pinot/spi/utils/BytesUtils.java 0.00% <0.00%> (-100.00%) ⬇️
.../java/org/apache/pinot/spi/utils/BooleanUtils.java 0.00% <0.00%> (-100.00%) ⬇️
...java/org/apache/pinot/spi/trace/BaseRecording.java 0.00% <0.00%> (-100.00%) ⬇️
...java/org/apache/pinot/spi/trace/NoOpRecording.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/config/table/FSTType.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/config/user/RoleType.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/data/MetricFieldSpec.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/utils/NullValueUtils.java 0.00% <0.00%> (-100.00%) ⬇️
...java/org/apache/pinot/common/tier/TierFactory.java 0.00% <0.00%> (-100.00%) ⬇️
... and 1413 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@siddharthteotia
Copy link
Contributor

Suggest adding some tests to test end to end query execution by using this function in different parts of the query -- example filter, select etc

@siddharthteotia
Copy link
Contributor

There is also LogicalOperatorTransformFunction. Should we implement this as part of that or a subclass of it ? It supports AND, OR and we want to add NOT

Just curious - how do you plan on using this as part of post aggregation ? Share a query example ? Would be good to have e2e query test

@siddharthteotia
Copy link
Contributor

siddharthteotia commented Sep 7, 2022

I didn't see the previous PR #9330 until now. Now it makes sense why we need this PR to handle post aggregation

@siddharthteotia siddharthteotia merged commit 0067b64 into apache:master Sep 7, 2022
@61yao 61yao deleted the not_scalar branch September 8, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants