[Feature] Support IsDistinctFrom and IsNotDistinctFrom #9312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61yao
force-pushed
the
is_distinct_from
branch
2 times, most recently
from
3b1e21a to
cffbec4
Compare
walterddr
reviewed
Sep 1, 2022
...ava/org/apache/pinot/core/operator/transform/function/DistinctFromTransformFunctionTest.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #9312 +/- ##
=============================================
- Coverage 63.40% 24.84% -38.57%
+ Complexity 4762 53 -4709
=============================================
Files 1832 1876 +44
Lines 98146 100105 +1959
Branches 15020 15251 +231
=============================================
- Hits 62231 24871 -37360
- Misses 31321 72701 +41380
+ Partials 4594 2533 -2061
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
61yao
force-pushed
the
is_distinct_from
branch
5 times, most recently
from
da884fe to
1213bf8
Compare
Jackie-Jiang
added
feature
release-notes
Jackie-Jiang
reviewed
Sep 7, 2022
.../java/org/apache/pinot/core/operator/transform/function/BinaryOperatorTransformFunction.java
Outdated
Show resolved
Hide resolved
...in/java/org/apache/pinot/core/operator/transform/function/DistinctFromTransformFunction.java
Outdated
Show resolved
Hide resolved
...in/java/org/apache/pinot/core/operator/transform/function/DistinctFromTransformFunction.java
Outdated
Show resolved
Hide resolved
...in/java/org/apache/pinot/core/operator/transform/function/DistinctFromTransformFunction.java
Outdated
Show resolved
Hide resolved
...in/java/org/apache/pinot/core/operator/transform/function/DistinctFromTransformFunction.java
Outdated
Show resolved
Hide resolved
...in/java/org/apache/pinot/core/operator/transform/function/DistinctFromTransformFunction.java
Outdated
Show resolved
Hide resolved
amrishlal
reviewed
Sep 7, 2022
...tion-tests/src/test/java/org/apache/pinot/integration/tests/NullHandlingIntegrationTest.java
Outdated
Show resolved
Hide resolved
61yao
force-pushed
the
is_distinct_from
branch
4 times, most recently
from
e4589f6 to
37724d7
Compare
Jackie-Jiang
reviewed
Sep 8, 2022
...in/java/org/apache/pinot/core/operator/transform/function/DistinctFromTransformFunction.java
Outdated
Show resolved
Hide resolved
...in/java/org/apache/pinot/core/operator/transform/function/DistinctFromTransformFunction.java
Outdated
Show resolved
Hide resolved
...in/java/org/apache/pinot/core/operator/transform/function/DistinctFromTransformFunction.java
Outdated
Show resolved
Hide resolved
Jackie-Jiang
reviewed
Sep 9, 2022
...in/java/org/apache/pinot/core/operator/transform/function/DistinctFromTransformFunction.java
Outdated
Show resolved
Hide resolved
...in/java/org/apache/pinot/core/operator/transform/function/DistinctFromTransformFunction.java
Outdated
Show resolved
Hide resolved
...in/java/org/apache/pinot/core/operator/transform/function/DistinctFromTransformFunction.java
Outdated
Show resolved
Hide resolved
...in/java/org/apache/pinot/core/operator/transform/function/DistinctFromTransformFunction.java
Outdated
Show resolved
Hide resolved
61yao
force-pushed
the
is_distinct_from
branch
2 times, most recently
from
eb5275d to
5237004
Compare
Jackie-Jiang
approved these changes
Sep 14, 2022
...in/java/org/apache/pinot/core/operator/transform/function/DistinctFromTransformFunction.java
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Suggested change
| protected DistinctFromTransformFunction(boolean distinctType) { | |
| protected DistinctFromTransformFunction(boolean distinct) { |
Contributor
There was a problem hiding this comment.
It should be faster if we iterate in the following way:
- Iterate over left null and set _distinctResult
- Iterate over right null and set _distinctResult
- Iterate over left AND right null and set _notDistinctResult
Contributor
Author
There was a problem hiding this comment.
Changed to iterate through xor and and bitset
added 8 commits
September 14, 2022 14:28
61yao
force-pushed
the
is_distinct_from
branch
from
0214c8e to
74fd9f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The operators IsDistinctFrom and IsNotDistinctFrom only supports column names as argument for now.
When null option is disabled, the row is considered as not null by default.
Expected value:
Null is IsDistinctFrom ValueA: True
Null is IsDistinctFrom Null: False
ValueA is IsDistinctFrom ValueB: NotEquals(ValueA, ValueB)
Null is IsNotDistinctFrom ValueA: False
Null is IsNotDistinctFrom Null: True
ValueA is IsNotDistinctFrom ValueB: Equals(ValueA, ValueB)
Example Usage:
ColumnA IsDistinctFrom ColumnB
ColumnA IsNotDistinctFrom ColumnB