Adding endpoint to download local log files for each component #9259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangfu0
force-pushed
the
adding_logger_file_entrypoint
branch
2 times, most recently
from
18b2a51 to
f1079d3
Compare
Codecov Report
@@ Coverage Diff @@
## master #9259 +/- ##
=============================================
- Coverage 69.93% 24.87% -45.07%
+ Complexity 5009 53 -4956
=============================================
Files 1860 1853 -7
Lines 99185 99234 +49
Branches 15082 15106 +24
=============================================
- Hits 69367 24683 -44684
- Misses 24905 72069 +47164
+ Partials 4913 2482 -2431
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xiangfu0
force-pushed
the
adding_logger_file_entrypoint
branch
8 times, most recently
from
6fcf0cc to
1c213da
Compare
xiangfu0
force-pushed
the
adding_logger_file_entrypoint
branch
2 times, most recently
from
6cbc9cb to
083aa21
Compare
KKcorps
reviewed
Aug 23, 2022
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotBrokerLogger.java
Outdated
Show resolved
Hide resolved
xiangfu0
force-pushed
the
adding_logger_file_entrypoint
branch
4 times, most recently
from
f7c608f to
9ba8d31
Compare
Jackie-Jiang
added
feature
release-notes
Jackie-Jiang
approved these changes
Aug 25, 2022
xiangfu0
force-pushed
the
adding_logger_file_entrypoint
branch
3 times, most recently
from
020b701 to
8778666
Compare
xiangfu0
force-pushed
the
adding_logger_file_entrypoint
branch
from
8778666 to
fa36a8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding endpoint to download local log files for each component for controller/broker/server/minion.
The purpose here is to simplify users debugging from the remote environment without access to containers.
E.g. users may have access only to controller LoadBalancer without the entire cluster, but want to debug a pinot server logger for why my real-time table is not ingesting, any issue with Kafka consumer or message decoder.
pinot.controller.logger.root.dir,pinot.broker.logger.root.dir,pinot.server.logger.root.dir,pinot.minion.logger.root.dir/loggers/files: List all the log files under the logger root directory./loggers/download?filePath={filePath}: Download the log file based on the relative path./loggers/instances: Collect log files from all the instances in the cluster./loggers/instances/{instanceName}: List all the log files for a given instance./loggers/instances/{instanceName}/download?filePath={filePath}: Download the log file from a given instance on a given path.