Optimize dateTimeConvert scalar function to only parse the format once #8939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackie-Jiang
force-pushed
the
optimize_date_time_convert
branch
from
fe1f8fe to
e103485
Compare
Codecov Report
@@ Coverage Diff @@
## master #8939 +/- ##
=============================================
- Coverage 69.69% 24.92% -44.78%
+ Complexity 4630 47 -4583
=============================================
Files 1813 1802 -11
Lines 94521 94171 -350
Branches 14116 14078 -38
=============================================
- Hits 65879 23469 -42410
- Misses 24033 68416 +44383
+ Partials 4609 2286 -2323
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
xiangfu0
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
dateTimeConvertscalar function stateful so that the format is parsed only once across multiple invocations. The state is persisted within the scope ofFunctionInvoker, so multiple functions with the same name won't share the same state.