fixing REGEX OPTION parser #8905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. only allow single OPTION keyword 2. only allow OPTION at end of file
Closed
Codecov Report
@@ Coverage Diff @@
## master #8905 +/- ##
============================================
- Coverage 69.74% 63.03% -6.72%
+ Complexity 4681 4662 -19
============================================
Files 1808 1761 -47
Lines 94276 92215 -2061
Branches 14057 13825 -232
============================================
- Hits 65756 58129 -7627
- Misses 23956 29916 +5960
+ Partials 4564 4170 -394
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Jackie-Jiang
added
release-notes
pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java
Outdated
Show resolved
Hide resolved
Jackie-Jiang
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Fixes REGEX OPTION can be parsed anywhere in the SQL including within a STRING literal.
See: #8906 for more details.
Details
Release Note
This PR introduces a backward incompatible change to
OPTIONkeyword parsing. MultipleOPTIONkeyword is no longer supported.For SQL such as
SELECT * FROM tbl OPTION(k1=v1) OPTION(k2=v2)please useSELECT * FROM tbl OPTION(k1=v1,k2=v2)