Support DISTINCT on multiple MV columns #8873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackie-Jiang
added
feature
release-notes
Codecov Report
@@ Coverage Diff @@
## master #8873 +/- ##
============================================
+ Coverage 69.71% 69.75% +0.03%
+ Complexity 4993 4600 -393
============================================
Files 1804 1805 +1
Lines 93883 94073 +190
Branches 13981 14039 +58
============================================
+ Hits 65453 65623 +170
- Misses 23884 23889 +5
- Partials 4546 4561 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
xiangfu0
approved these changes
Jun 9, 2022
Contributor
|
Please put examples for release notes of the multi-value behavior. |
dongxiaoman
pushed a commit
to dongxiaoman/incubator-pinot
that referenced
this pull request
Jun 13, 2022
- Support DISTINCT on multiple columns (including MV). - The behavior is the same as group-by on multiple columns, where we return all the value combinations if there are multiple MV columns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subtask of #8850
E.g. If a row has
colA (MV): [0, 1],colB (MV): [2, 3],colC (SV): 4,SELECT DISTINCT colA, colB, colCwill get 4 combinations from this row:[0, 2, 4], [0, 3, 4], [1, 2, 4], [1, 3, 4]Release-Notes
Support DISTINCT on multiple MV columns. The behavior is the same as group-by on multiple columns (return all the value combinations if there are multiple MV columns).