Skip to content

Support DISTINCT on single MV column #8857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Jackie-Jiang merged 1 commit into from
Jun 8, 2022
Merged

Support DISTINCT on single MV column #8857

Jackie-Jiang merged 1 commit into from
Jun 8, 2022

Conversation

@Jackie-Jiang
Copy link
Contributor

@Jackie-Jiang Jackie-Jiang commented Jun 7, 2022

Subtask of #8850

  • Support DISTINCT on single MV column.
  • Add test for DISTINCT over Big-decimal and single MV columns

Release-Notes

Support DISTINCT on single MV column

@Jackie-Jiang Jackie-Jiang added feature release-notes Referenced by PRs that need attention when compiling the next release notes labels Jun 7, 2022
@Jackie-Jiang Jackie-Jiang requested a review from xiangfu0 June 7, 2022 23:14
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2022 •
edited
Loading

Codecov Report

Merging #8857 (869c949) into master (8a71323) will increase coverage by 1.26%.
The diff coverage is 55.20%.

@@             Coverage Diff              @@
##             master    #8857      +/-   ##
============================================
+ Coverage     68.45%   69.72%   +1.26%     
- Complexity     4651     4669      +18     
============================================
  Files          1741     1741              
  Lines         91521    91608      +87     
  Branches      13691    13729      +38     
============================================
+ Hits          62650    63872    +1222     
+ Misses        24472    23292    -1180     
- Partials       4399     4444      +45
Flag Coverage Δ
integration1 26.98% <3.64%> (+0.06%) ⬆️
integration2 25.62% <3.64%> (?)
unittests1 66.13% <54.16%> (-0.06%) ⬇️
unittests2 14.12% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ctionaryBasedSingleColumnDistinctOnlyExecutor.java 0.00% <0.00%> (ø)
.../raw/RawFloatSingleColumnDistinctOnlyExecutor.java 44.44% <30.76%> (-35.56%) ⬇️
...ct/raw/RawIntSingleColumnDistinctOnlyExecutor.java 44.44% <30.76%> (-35.56%) ⬇️
...t/raw/RawLongSingleColumnDistinctOnlyExecutor.java 44.44% <30.76%> (-35.56%) ⬇️
...raw/RawStringSingleColumnDistinctOnlyExecutor.java 44.44% <30.76%> (-35.56%) ⬇️
...raw/RawDoubleSingleColumnDistinctOnlyExecutor.java 61.11% <46.15%> (-38.89%) ⬇️
...onaryBasedSingleColumnDistinctOrderByExecutor.java 76.66% <72.22%> (-14.64%) ⬇️
.../RawDoubleSingleColumnDistinctOrderByExecutor.java 76.66% <72.22%> (-14.64%) ⬇️
...w/RawFloatSingleColumnDistinctOrderByExecutor.java 76.66% <72.22%> (-14.64%) ⬇️
...raw/RawIntSingleColumnDistinctOrderByExecutor.java 76.66% <72.22%> (-14.64%) ⬇️
... and 148 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a71323...869c949. Read the comment docs.

xiangfu0
xiangfu0 approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@xiangfu0 xiangfu0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jackie-Jiang Jackie-Jiang merged commit da0b74a into apache:master Jun 8, 2022
@Jackie-Jiang Jackie-Jiang deleted the distinct_mv branch June 8, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiangfu0 xiangfu0 xiangfu0 approved these changes

Assignees

No one assigned

Labels

feature release-notes Referenced by PRs that need attention when compiling the next release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Jackie-Jiang @codecov-commenter @xiangfu0