Skip to content

Conversation

@KKcorps
Copy link
Contributor

@KKcorps KKcorps commented May 28, 2022

When pinot-parquet plugin is used in a Spark YARN cluster, it can cause issues due to hadoop dependencies being bundled with the plugin. These deps can't be used in provided scope due to #6743. The solution is to shade these deps.

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2022

Codecov Report

Merging #8798 (a293444) into master (73316a6) will decrease coverage by 0.55%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #8798      +/-   ##
============================================
- Coverage     68.51%   67.95%   -0.56%     
- Complexity     4601     4618      +17     
============================================
  Files          1736     1733       -3     
  Lines         91196    91202       +6     
  Branches      13633    13631       -2     
============================================
- Hits          62480    61974     -506     
- Misses        24330    24893     +563     
+ Partials       4386     4335      -51     
Flag Coverage Δ
integration1 ?
integration2 25.22% <ø> (?)
unittests1 66.16% <ø> (+0.01%) ⬆️
unittests2 14.15% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...pinot/minion/exception/TaskCancelledException.java 0.00% <0.00%> (-100.00%) ⬇️
...nverttorawindex/ConvertToRawIndexTaskExecutor.java 0.00% <0.00%> (-100.00%) ⬇️
...e/pinot/common/minion/MergeRollupTaskMetadata.java 0.00% <0.00%> (-94.74%) ⬇️
...plugin/segmentuploader/SegmentUploaderDefault.java 0.00% <0.00%> (-87.10%) ⬇️
.../transform/function/MapValueTransformFunction.java 0.00% <0.00%> (-85.30%) ⬇️
...ot/common/messages/RoutingTableRebuildMessage.java 0.00% <0.00%> (-81.82%) ⬇️
...data/manager/realtime/DefaultSegmentCommitter.java 0.00% <0.00%> (-80.00%) ⬇️
...verttorawindex/ConvertToRawIndexTaskGenerator.java 5.45% <0.00%> (-80.00%) ⬇️
...ache/pinot/common/lineage/SegmentLineageUtils.java 22.22% <0.00%> (-77.78%) ⬇️
...ore/startree/executor/StarTreeGroupByExecutor.java 0.00% <0.00%> (-77.78%) ⬇️
... and 231 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73316a6...a293444. Read the comment docs.

@jackjlli jackjlli merged commit b597226 into apache:master May 31, 2022
@npawar npawar mentioned this pull request Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants