Allow broker to automatically rewrite expensive function to its approximate counterpart #8655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackie-Jiang
added
enhancement
release-notes
…ximate counterpart
Jackie-Jiang
force-pushed
the
automatic_approximate_query_rewrite
branch
from
82ea0d7 to
c036b99
Compare
Codecov Report
@@ Coverage Diff @@
## master #8655 +/- ##
============================================
+ Coverage 70.35% 70.40% +0.05%
Complexity 4406 4406
============================================
Files 1690 1690
Lines 88187 88249 +62
Branches 13190 13204 +14
============================================
+ Hits 62042 62135 +93
+ Misses 21856 21829 -27
+ Partials 4289 4285 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
xiangfu0
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release-Notes
Add broker config
pinot.broker.use.approximate.functionto turn the feature on (off by default)Add query config
useApproximateFunctionto override the broker level config