allow to take data outside the time window by negating the window filter #8640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klsince
force-pushed
the
allow_to_negate_window_filter
branch
from
17bb54f to
7712432
Compare
Codecov Report
@@ Coverage Diff @@
## master #8640 +/- ##
============================================
- Coverage 70.59% 66.46% -4.14%
+ Complexity 4411 4330 -81
============================================
Files 1677 1261 -416
Lines 87707 63844 -23863
Branches 13145 9920 -3225
============================================
- Hits 61921 42434 -19487
+ Misses 21496 18402 -3094
+ Partials 4290 3008 -1282
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
klsince
force-pushed
the
allow_to_negate_window_filter
branch
from
bceb06f to
3206d2e
Compare
Jackie-Jiang
approved these changes
May 5, 2022
...re/src/main/java/org/apache/pinot/core/segment/processing/timehandler/TimeHandlerConfig.java
Outdated
Show resolved
Hide resolved
...re/src/main/java/org/apache/pinot/core/segment/processing/timehandler/TimeHandlerConfig.java
Outdated
Show resolved
Hide resolved
Jackie-Jiang
added
release-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add config
negateWindowFilterto let SegmentProcessorFramework take data outside the time window when generating segmentsRelease Note
new config
negateWindowFilterfor SegmentProcessorFramework. It's false by default to be backward compatible.