Skip to content

Package kafka 0.9 shaded jar to pinot-distribution #8569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xiangfu0 merged 2 commits into from
Apr 21, 2022
Merged

Package kafka 0.9 shaded jar to pinot-distribution #8569

xiangfu0 merged 2 commits into from
Apr 21, 2022

Conversation

@xiangfu0
Copy link
Contributor

@xiangfu0 xiangfu0 commented Apr 20, 2022 •
edited
Loading

Package Kafka 0.9 shaded jar to pinot-distribution.

➜  find pinot-distribution/target/apache-pinot-0.11.0-SNAPSHOT-bin/apache-pinot-0.11.0-SNAPSHOT-bin/plugins/pinot-stream-ingestion 
pinot-distribution/target/apache-pinot-0.11.0-SNAPSHOT-bin/apache-pinot-0.11.0-SNAPSHOT-bin/plugins/pinot-stream-ingestion
pinot-distribution/target/apache-pinot-0.11.0-SNAPSHOT-bin/apache-pinot-0.11.0-SNAPSHOT-bin/plugins/pinot-stream-ingestion/pinot-kafka-0.9
pinot-distribution/target/apache-pinot-0.11.0-SNAPSHOT-bin/apache-pinot-0.11.0-SNAPSHOT-bin/plugins/pinot-stream-ingestion/pinot-kafka-0.9/pinot-kafka-0.9-0.11.0-SNAPSHOT-shaded.jar
pinot-distribution/target/apache-pinot-0.11.0-SNAPSHOT-bin/apache-pinot-0.11.0-SNAPSHOT-bin/plugins/pinot-stream-ingestion/pinot-kafka-2.0
pinot-distribution/target/apache-pinot-0.11.0-SNAPSHOT-bin/apache-pinot-0.11.0-SNAPSHOT-bin/plugins/pinot-stream-ingestion/pinot-kafka-2.0/pinot-kafka-2.0-0.11.0-SNAPSHOT-shaded.jar
pinot-distribution/target/apache-pinot-0.11.0-SNAPSHOT-bin/apache-pinot-0.11.0-SNAPSHOT-bin/plugins/pinot-stream-ingestion/pinot-kinesis
pinot-distribution/target/apache-pinot-0.11.0-SNAPSHOT-bin/apache-pinot-0.11.0-SNAPSHOT-bin/plugins/pinot-stream-ingestion/pinot-kinesis/pinot-kinesis-0.11.0-SNAPSHOT-shaded.jar

@xiangfu0 xiangfu0 added the release-notes Referenced by PRs that need attention when compiling the next release notes label Apr 20, 2022
@KKcorps
Copy link
Contributor

KKcorps commented Apr 20, 2022

LGTM!

@xiangfu0 xiangfu0 force-pushed the package_kafka0.9 branch 2 times, most recently from 7a35edf to 9867381 Compare April 20, 2022 08:39
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2022 •
edited
Loading

Codecov Report

Merging #8569 (5e63e4d) into master (fe14231) will increase coverage by 6.82%.
The diff coverage is 80.64%.

❗ Current head 5e63e4d differs from pull request most recent head 1db2b45. Consider uploading reports for the commit 1db2b45 to get more accurate results

@@             Coverage Diff              @@
##             master    #8569      +/-   ##
============================================
+ Coverage     63.89%   70.72%   +6.82%     
  Complexity     4308     4308              
============================================
  Files          1645     1690      +45     
  Lines         86524    88462    +1938     
  Branches      13183    13400     +217     
============================================
+ Hits          55284    62564    +7280     
+ Misses        27228    21530    -5698     
- Partials       4012     4368     +356
Flag Coverage Δ
integration1 27.23% <61.29%> (?)
integration2 25.86% <69.35%> (?)
unittests1 66.91% <0.00%> (+<0.01%) ⬆️
unittests2 14.01% <74.19%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ing/instanceselector/BalancedInstanceSelector.java 100.00% <ø> (ø)
...va/org/apache/pinot/spi/utils/CommonConstants.java 21.31% <ø> (ø)
...roker/requesthandler/BaseBrokerRequestHandler.java 50.50% <28.57%> (+27.67%) ⬆️
.../org/apache/pinot/core/util/QueryOptionsUtils.java 72.22% <50.00%> (+15.97%) ⬆️
...not/broker/broker/helix/ClusterChangeMediator.java 80.64% <85.00%> (+6.17%) ⬆️
...routing/instanceselector/BaseInstanceSelector.java 100.00% <100.00%> (+1.85%) ⬆️
...instanceselector/ReplicaGroupInstanceSelector.java 100.00% <100.00%> (ø)
...he/pinot/segment/local/segment/store/IndexKey.java 75.00% <0.00%> (-5.00%) ⬇️
...ot/server/api/resources/PinotServerAppConfigs.java 0.00% <0.00%> (ø)
...t/plugin/metrics/yammer/YammerMetricsRegistry.java 60.00% <0.00%> (ø)
... and 384 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe14231...1db2b45. Read the comment docs.

@xiangfu0 xiangfu0 force-pushed the package_kafka0.9 branch 7 times, most recently from fb503e1 to 18d1a07 Compare April 21, 2022 07:50
@xiangfu0 xiangfu0 force-pushed the package_kafka0.9 branch 2 times, most recently from 10c3b31 to 3f88606 Compare April 21, 2022 10:33
@xiangfu0 xiangfu0 merged commit d158478 into apache:master Apr 21, 2022
@xiangfu0 xiangfu0 deleted the package_kafka0.9 branch April 21, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KKcorps KKcorps KKcorps approved these changes

@Jackie-Jiang Jackie-Jiang Awaiting requested review from Jackie-Jiang

Assignees

No one assigned

Labels

release-notes Referenced by PRs that need attention when compiling the next release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xiangfu0 @KKcorps @codecov-commenter