Only discover public methods annotated with @ScalarFunction #8544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8544 +/- ##
=============================================
- Coverage 70.65% 29.35% -41.31%
=============================================
Files 1674 1669 -5
Lines 87743 87602 -141
Branches 13279 13282 +3
=============================================
- Hits 61999 25713 -36286
- Misses 21439 59508 +38069
+ Partials 4305 2381 -1924
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Member
Author
|
It appears illegal reflective access is relied on even internally |
siddharthteotia
approved these changes
Apr 14, 2022
richardstartin
added
release-notes
richardstartin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop discovering private scalar functions to avoid unpredictable illegal reflective access.
This is a breaking change; if a user has a non-public method annotated with
@ScalarFunctionthen it will no longer be evaluated. The migration path is for the user to make the appropriate methods public, since they own the code.