I'm curious why this (and the _name variable) aren't static. Is there a convention in the Pinot code base? Just FYI, I found 437 instances of static final Logger LOGGER, and 14 of final Logger _logger (a few of which were actually static).

This is a base class, and we want to log the actual class name that extends this base class, so it cannot be static. E.g. I want the logger to log under ConnectionFailureDetector instead of BaseExponentialBackoffRetryFailureDetector

Thanks for clarifying...but why do you want classes that extend BaseExponentialBackoffRetryFailureDetector to use its logger? Is there some issue with the concrete class having its own logger?

Just asking because I see 25+ instances of abstract classes with private static loggers, but only one other class BaseSegmentJob that does the same thing as here.

BaseSegmentFetcher is also following this pattern, but you are right the majority of the abstract classes use the static logger. IMO it doesn't matter because there is only one single failure detector instance running, so no extra overhead, but I'm okay changing it to a static one for consistency