Allow overriding expression in query through query config #8319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackie-Jiang
added
feature
release-notes
mayankshriv
approved these changes
Mar 9, 2022
Codecov Report
@@ Coverage Diff @@
## master #8319 +/- ##
=============================================
- Coverage 70.87% 28.82% -42.06%
=============================================
Files 1635 1623 -12
Lines 85676 85393 -283
Branches 12900 12876 -24
=============================================
- Hits 60726 24616 -36110
- Misses 20758 58507 +37749
+ Partials 4192 2270 -1922
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow broker to override expressions in query automatically if configured in the query config.
In certain scenarios, users cannot control the queries sent to pinot (e.g. queries are auto-generated by some other tools), then they can use this feature to override the expressions within the query to the desired ones by putting the query config (e.g. override transform function to derived column).
Release Notes
Add a new config
expressionOverrideMapunder theQueryConfig