[Presto pinot driver] Adding NoopPinotMetricFactory and corresponding changes #8270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangfu0
force-pushed
the
adding_noop_metrics
branch
3 times, most recently
from
a7de902 to
8386f54
Compare
Codecov Report
@@ Coverage Diff @@
## master #8270 +/- ##
============================================
- Coverage 70.81% 70.74% -0.08%
+ Complexity 4244 4241 -3
============================================
Files 1631 1631
Lines 85454 85454
Branches 12877 12877
============================================
- Hits 60515 60455 -60
- Misses 20758 20824 +66
+ Partials 4181 4175 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
xiangfu0
force-pushed
the
adding_noop_metrics
branch
from
8386f54 to
775ac8a
Compare
xiangfu0
changed the title
Jackie-Jiang
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create NoopPinotMetricFactory for
PinotScatterGatherQueryClientto bypass the requirement forpinot-yammerruntime dependency.Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
backward-incompat, and complete the section below on Release Notes)Does this PR fix a zero-downtime upgrade introduced earlier?
backward-incompat, and complete the section below on Release Notes)Does this PR otherwise need attention when creating release notes? Things to consider:
release-notesand complete the section on Release Notes)Release Notes
Documentation