Skip to content

Include docIds in Projection and Transform block #8262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Jackie-Jiang merged 1 commit into from
Feb 28, 2022
Merged

Include docIds in Projection and Transform block #8262

Jackie-Jiang merged 1 commit into from
Feb 28, 2022

Conversation

@Jackie-Jiang
Copy link
Contributor

@Jackie-Jiang Jackie-Jiang commented Feb 28, 2022

  • Allow reading docIds from ProjectionBlock and TransformBlock
  • Remove the extra access of $docId virtual column in SelectionOrderByOperator
  • Bug fixes in SelectionPlanNode for all column sorted optimization

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2022

Codecov Report

Merging #8262 (4f77126) into master (e6330bb) will decrease coverage by 49.88%.
The diff coverage is 43.72%.

❗ Current head 4f77126 differs from pull request most recent head cbf8675. Consider uploading reports for the commit cbf8675 to get more accurate results

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #8262       +/-   ##
=============================================
- Coverage     64.06%   14.17%   -49.89%     
+ Complexity     4246       81     -4165     
=============================================
  Files          1586     1586               
  Lines         83399    83550      +151     
  Branches      12641    12667       +26     
=============================================
- Hits          53427    11847    -41580     
- Misses        26129    70817    +44688     
+ Partials       3843      886     -2957
Flag Coverage Δ
unittests1 ?
unittests2 14.17% <43.72%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ache/pinot/common/metadata/ZKMetadataProvider.java 0.00% <0.00%> (-20.15%) ⬇️
...g/apache/pinot/common/utils/helix/HelixHelper.java 0.00% <0.00%> (-16.02%) ⬇️
...a/org/apache/pinot/core/common/DataBlockCache.java 0.00% <0.00%> (-88.58%) ⬇️
...he/pinot/core/operator/blocks/ProjectionBlock.java 0.00% <0.00%> (-60.00%) ⬇️
...che/pinot/core/operator/blocks/TransformBlock.java 0.00% <0.00%> (-69.24%) ⬇️
.../core/operator/query/SelectionOrderByOperator.java 0.00% <0.00%> (-91.94%) ⬇️
.../org/apache/pinot/core/plan/SelectionPlanNode.java 0.00% <0.00%> (-100.00%) ⬇️
...er/api/resources/PinotInstanceRestletResource.java 51.48% <50.00%> (-4.08%) ⬇️
...e/pinot/broker/broker/helix/BaseBrokerStarter.java 72.58% <77.77%> (+0.69%) ⬆️
...ntroller/helix/core/PinotHelixResourceManager.java 63.31% <82.55%> (+1.12%) ⬆️
... and 1100 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6330bb...cbf8675. Read the comment docs.

@Jackie-Jiang Jackie-Jiang merged commit 7cfa2e4 into apache:master Feb 28, 2022
@Jackie-Jiang Jackie-Jiang deleted the pass_doc_ids branch February 28, 2022 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiangfu0 xiangfu0 xiangfu0 approved these changes

@mayankshriv mayankshriv mayankshriv approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Jackie-Jiang @codecov-commenter @xiangfu0 @mayankshriv