[pinot docker image] cache prometheus rules #8241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardstartin
changed the title
Codecov Report
@@ Coverage Diff @@
## master #8241 +/- ##
=============================================
- Coverage 70.66% 27.46% -43.21%
=============================================
Files 1629 1617 -12
Lines 85140 84786 -354
Branches 12815 12777 -38
=============================================
- Hits 60166 23286 -36880
- Misses 20816 59329 +38513
+ Partials 4158 2171 -1987
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
walterddr
approved these changes
Feb 23, 2022
Contributor
walterddr
left a comment
walterddr
left a comment
There was a problem hiding this comment.
lgtm.
not introduced by this PR but we should address the end of file new line some time in checkstyle rules.
Jackie-Jiang
approved these changes
Feb 23, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.