Skip to content

In BrokerRequestToQueryContextConverter, remove unused filterExpressionContext #8238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Jackie-Jiang merged 1 commit into from
Feb 22, 2022
Merged

In BrokerRequestToQueryContextConverter, remove unused filterExpressionContext #8238

Jackie-Jiang merged 1 commit into from
Feb 22, 2022

Conversation

@Jackie-Jiang
Copy link
Contributor

@Jackie-Jiang Jackie-Jiang commented Feb 21, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2022 •
edited
Loading

Codecov Report

Merging #8238 (64d7efc) into master (21632da) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8238      +/-   ##
============================================
- Coverage     71.00%   70.99%   -0.01%     
  Complexity     4320     4320              
============================================
  Files          1629     1629              
  Lines         85132    85130       -2     
  Branches      12812    12812              
============================================
- Hits          60445    60442       -3     
+ Misses        20526    20525       -1     
- Partials       4161     4163       +2
Flag Coverage Δ
integration1 28.68% <100.00%> (-0.02%) ⬇️
integration2 27.56% <100.00%> (-0.06%) ⬇️
unittests1 67.37% <100.00%> (-0.01%) ⬇️
unittests2 14.15% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...xt/utils/BrokerRequestToQueryContextConverter.java 98.38% <100.00%> (-0.03%) ⬇️
...ller/helix/core/minion/TaskTypeMetricsUpdater.java 80.00% <0.00%> (-20.00%) ⬇️
...a/org/apache/pinot/common/utils/ServiceStatus.java 60.00% <0.00%> (-7.15%) ⬇️
.../api/exception/ControllerApplicationException.java 66.66% <0.00%> (-6.67%) ⬇️
...gregation/function/StUnionAggregationFunction.java 73.52% <0.00%> (-2.95%) ⬇️
.../pinot/server/starter/helix/BaseServerStarter.java 57.98% <0.00%> (-1.97%) ⬇️
...e/pinot/broker/broker/helix/BaseBrokerStarter.java 75.67% <0.00%> (-1.09%) ⬇️
...lix/core/realtime/PinotRealtimeSegmentManager.java 82.72% <0.00%> (-1.05%) ⬇️
...core/startree/operator/StarTreeFilterOperator.java 86.71% <0.00%> (-0.70%) ⬇️
...apache/pinot/controller/BaseControllerStarter.java 82.16% <0.00%> (-0.32%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21632da...64d7efc. Read the comment docs.

@Jackie-Jiang Jackie-Jiang merged commit ff21071 into apache:master Feb 22, 2022
@Jackie-Jiang Jackie-Jiang deleted the remove_unused_filter_expression branch February 22, 2022 22:17
xiangfu0 pushed a commit to xiangfu0/pinot that referenced this pull request Feb 23, 2022
@Jackie-Jiang @xiangfu0
In BrokerRequestToQueryContextConverter, remove unused filterExpressi…
fdcb26b 
…onContext (apache#8238)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atris atris atris approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Jackie-Jiang @codecov-commenter @atris