Skip to content

Conversation

@xiangfu0
Copy link
Contributor

@xiangfu0 xiangfu0 commented Feb 18, 2022

Description

Capture the new python pinot client 0.3.9 release: pinotdb

Upgrade Notes

Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

  • Yes (Please label as backward-incompat, and complete the section below on Release Notes)

Does this PR fix a zero-downtime upgrade introduced earlier?

  • Yes (Please label this as backward-incompat, and complete the section below on Release Notes)

Does this PR otherwise need attention when creating release notes? Things to consider:

  • New configuration options
  • Deprecation of configurations
  • Signature changes to public methods/interfaces
  • New plugins added or old plugins removed
  • Yes (Please label this PR as release-notes and complete the section on Release Notes)

Release Notes

Documentation

@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2022

Codecov Report

Merging #8231 (3dfbfaf) into master (d047e7b) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8231      +/-   ##
============================================
- Coverage     71.02%   70.99%   -0.03%     
- Complexity     4314     4320       +6     
============================================
  Files          1626     1626              
  Lines         84977    85067      +90     
  Branches      12790    12799       +9     
============================================
+ Hits          60352    60395      +43     
- Misses        20472    20518      +46     
- Partials       4153     4154       +1     
Flag Coverage Δ
integration1 28.72% <ø> (+0.01%) ⬆️
integration2 27.61% <ø> (+0.15%) ⬆️
unittests1 67.34% <ø> (+<0.01%) ⬆️
unittests2 14.11% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...a/manager/realtime/RealtimeSegmentDataManager.java 50.00% <0.00%> (-25.00%) ⬇️
...pinot/common/utils/fetcher/HttpSegmentFetcher.java 61.53% <0.00%> (-10.26%) ⬇️
...a/org/apache/pinot/common/utils/ServiceStatus.java 60.00% <0.00%> (-7.62%) ⬇️
.../api/exception/ControllerApplicationException.java 66.66% <0.00%> (-6.67%) ⬇️
...he/pinot/segment/local/segment/store/IndexKey.java 70.00% <0.00%> (-5.00%) ⬇️
...apache/pinot/controller/api/upload/ZKOperator.java 74.80% <0.00%> (-3.15%) ⬇️
...ces/PinotSegmentUploadDownloadRestletResource.java 57.51% <0.00%> (-2.58%) ⬇️
...not/broker/broker/helix/ClusterChangeMediator.java 77.65% <0.00%> (-2.13%) ⬇️
...lix/core/realtime/PinotRealtimeSegmentManager.java 80.62% <0.00%> (-2.10%) ⬇️
.../pinot/server/starter/helix/BaseServerStarter.java 57.98% <0.00%> (-1.97%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d047e7b...3dfbfaf. Read the comment docs.

@xiangfu0 xiangfu0 requested a review from apucher February 19, 2022 00:54
@xiangfu0 xiangfu0 merged commit 3abafb8 into apache:master Feb 19, 2022
@xiangfu0 xiangfu0 deleted the superset-docker-image-pinotdb branch February 19, 2022 04:33
xiangfu0 added a commit to xiangfu0/pinot that referenced this pull request Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants