allow segment name postfix for SegmentProcessorFramework #8230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in NormalizedDate name generator
Jackie-Jiang
approved these changes
Feb 18, 2022
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/framework/SegmentConfig.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #8230 +/- ##
============================================
- Coverage 71.01% 64.33% -6.68%
Complexity 4320 4320
============================================
Files 1626 1581 -45
Lines 85067 83194 -1873
Branches 12799 12598 -201
============================================
- Hits 60408 53523 -6885
- Misses 20505 25825 +5320
+ Partials 4154 3846 -308
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
xiangfu0
pushed a commit
to xiangfu0/pinot
that referenced
this pull request
Feb 23, 2022
Allow to set segment name postfix when using SegmentProcessorFramework, right now that's hard coded as null. Meanwhile, fix a bug in NormalizedDate name generator, right now it doesn't join postfix into segment name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to set segment name postfix when using SegmentProcessorFramework, right now that's hard coded as null.
Meanwhile, fix a bug in NormalizedDate name generator, right now it doesn't join postfix into segment name.
Description
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
backward-incompat, and complete the section below on Release Notes)Does this PR fix a zero-downtime upgrade introduced earlier?
backward-incompat, and complete the section below on Release Notes)Does this PR otherwise need attention when creating release notes? Things to consider:
release-notesand complete the section on Release Notes)Release Notes
Documentation