Allow subclass to customize what happens pre/post segment uploading #8203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klsince
force-pushed
the
customize_segment_uploading
branch
from
87f33a0 to
1bfdb6c
Compare
klsince
changed the title
Codecov Report
@@ Coverage Diff @@
## master #8203 +/- ##
============================================
+ Coverage 71.01% 71.03% +0.01%
Complexity 4314 4314
============================================
Files 1624 1624
Lines 84873 84891 +18
Branches 12791 12791
============================================
+ Hits 60273 60299 +26
+ Misses 20453 20439 -14
- Partials 4147 4153 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Comment on lines
105
to
108
| String tableNameWithType = configs.get(MinionConstants.TABLE_NAME_KEY); | ||
| String inputSegmentNames = configs.get(MinionConstants.SEGMENT_NAME_KEY); | ||
| String uploadURL = configs.get(MinionConstants.UPLOAD_URL_KEY); | ||
| String authToken = configs.get(MinionConstants.AUTH_TOKEN); |
Contributor
There was a problem hiding this comment.
These info are extracted multiple times. Shall we consider adding a context class to wrap them and pass them into this method? We can also have a custom map within the context class so that other custom fields can be added.
Jackie-Jiang
approved these changes
Feb 16, 2022
xiangfu0
pushed a commit
to xiangfu0/pinot
that referenced
this pull request
Feb 23, 2022
…pache#8203) Added pre/postUploadSegments() methods for BaseMultipleSegmentsConversionExecutor, so that subclass can customize what happens before/after segment uploading, e.g. RT2OFF task should use segment lineage against the dest offline table instead of the src realtime table, but MergeRollup uses segment lineage against a single table that is both src/dest table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added pre/postUploadSegments() methods for BaseMultipleSegmentsConversionExecutor, so that subclass can customize what happens before/after segment uploading, e.g. RT2OFF task should use segment lineage against the dest offline table instead of the src realtime table, but MergeRollup uses segment lineage against a single table that is both src/dest table.
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
backward-incompat, and complete the section below on Release Notes)Does this PR fix a zero-downtime upgrade introduced earlier?
backward-incompat, and complete the section below on Release Notes)Does this PR otherwise need attention when creating release notes? Things to consider:
release-notesand complete the section on Release Notes)Release Notes
Documentation