Skip to content

Conversation

@xiangfu0
Copy link
Contributor

@xiangfu0 xiangfu0 commented Feb 10, 2022

Description

Change the behavior from default PQL to configurable and deprecate existing PQL api.

Upgrade Notes

Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

  • Yes (Please label as backward-incompat, and complete the section below on Release Notes)

Does this PR fix a zero-downtime upgrade introduced earlier?

  • Yes (Please label this as backward-incompat, and complete the section below on Release Notes)

Does this PR otherwise need attention when creating release notes? Things to consider:

  • New configuration options
  • Deprecation of configurations
  • Signature changes to public methods/interfaces
  • New plugins added or old plugins removed
  • Yes (Please label this PR as release-notes and complete the section on Release Notes)

Release Notes

Documentation

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2022

Codecov Report

Merging #8186 (d37d4f9) into master (8d867ed) will decrease coverage by 57.16%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #8186       +/-   ##
=============================================
- Coverage     71.35%   14.19%   -57.17%     
+ Complexity     4306       81     -4225     
=============================================
  Files          1623     1578       -45     
  Lines         84314    82433     -1881     
  Branches      12640    12436      -204     
=============================================
- Hits          60163    11699    -48464     
- Misses        20035    69861    +49826     
+ Partials       4116      873     -3243     
Flag Coverage Δ
integration1 ?
integration2 ?
unittests1 ?
unittests2 14.19% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ain/java/org/apache/pinot/core/data/table/Key.java 0.00% <0.00%> (-100.00%) ⬇️
.../java/org/apache/pinot/spi/utils/BooleanUtils.java 0.00% <0.00%> (-100.00%) ⬇️
.../java/org/apache/pinot/core/data/table/Record.java 0.00% <0.00%> (-100.00%) ⬇️
.../java/org/apache/pinot/core/util/GroupByUtils.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/config/table/FSTType.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/data/MetricFieldSpec.java 0.00% <0.00%> (-100.00%) ⬇️
...va/org/apache/pinot/spi/utils/BigDecimalUtils.java 0.00% <0.00%> (-100.00%) ⬇️
...java/org/apache/pinot/common/tier/TierFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...java/org/apache/pinot/common/utils/StringUtil.java 0.00% <0.00%> (-100.00%) ⬇️
...va/org/apache/pinot/core/data/table/BaseTable.java 0.00% <0.00%> (-100.00%) ⬇️
... and 1292 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d867ed...d37d4f9. Read the comment docs.

@xiangfu0 xiangfu0 force-pushed the presto_server_client_compiler_switch branch from c446d8f to d37d4f9 Compare February 10, 2022 07:20
@xiangfu0 xiangfu0 changed the title Make presto server queries leverage query format Make presto driver query pinot server with query format Feb 10, 2022
@xiangfu0 xiangfu0 force-pushed the presto_server_client_compiler_switch branch from d37d4f9 to a1d4bcf Compare February 10, 2022 19:13
@Jackie-Jiang Jackie-Jiang changed the title Make presto driver query pinot server with query format Make presto driver query pinot server with SQL Feb 10, 2022
@xiangfu0 xiangfu0 merged commit 83662be into apache:master Feb 10, 2022
@xiangfu0 xiangfu0 deleted the presto_server_client_compiler_switch branch February 10, 2022 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants