add FIRSTWITHTIME aggregate function support #7647 #8181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The new added tests are failing. Can you please rebase to the latest master? The quickstart test failure is not related to this PR |
Codecov Report
@@ Coverage Diff @@
## master #8181 +/- ##
============================================
+ Coverage 69.49% 69.60% +0.10%
+ Complexity 4412 4411 -1
============================================
Files 1667 1673 +6
Lines 87320 87595 +275
Branches 13086 13127 +41
============================================
+ Hits 60687 60968 +281
+ Misses 22401 22382 -19
- Partials 4232 4245 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Jackie-Jiang
approved these changes
May 4, 2022
Jackie-Jiang
added
release-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding aggregate function to return first value of time-based data set.
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
backward-incompat, and complete the section below on Release Notes)Does this PR fix a zero-downtime upgrade introduced earlier?
backward-incompat, and complete the section below on Release Notes)Does this PR otherwise need attention when creating release notes? Things to consider:
release-notesand complete the section on Release Notes)Release Notes
add FIRSTWITHTIME aggregate function support
Documentation
Will raise an another PR to update the documentation once this PR is approved and the changes are finalized.