Implement NOT Operator #8148

atris · 2022-02-07T10:21:43Z

This PR implements the NOT operator.

NOT operator is implemented in a generic manner i.e. it can support most underlying operators.

The operator operates by "skipping" documents that are valid for the underlying predicate and iterating over all other valid docIDs.

Support for LIKE operator is not present yet due to Calcite's slightly different parsing of the LIKE operator.

siddharthteotia · 2022-02-07T17:38:30Z

Thanks for the change, @atris . I will review today

codecov-commenter · 2022-02-09T08:54:26Z

Codecov Report

Attention: Patch coverage is 78.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 71.08%. Comparing base (5fa4737) to head (bcb3886).
Report is 4683 commits behind head on master.

Files with missing lines	Patch %	Lines
...inot/core/operator/filter/FilterOperatorUtils.java	42.85%	2 Missing and 2 partials ⚠️
.../pinot/core/operator/filter/NotFilterOperator.java	55.55%	4 Missing ⚠️
...ot/common/request/context/RequestContextUtils.java	50.00%	0 Missing and 1 partial ⚠️
...core/operator/dociditerators/NotDocIdIterator.java	95.00%	0 Missing and 1 partial ⚠️
...ava/org/apache/pinot/core/plan/FilterPlanNode.java	75.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #8148      +/-   ##
============================================
- Coverage     71.41%   71.08%   -0.33%     
- Complexity     4302     4319      +17     
============================================
  Files          1623     1629       +6     
  Lines         84312    85132     +820     
  Branches      12639    12812     +173     
============================================
+ Hits          60213    60518     +305     
- Misses        19974    20459     +485     
- Partials       4125     4155      +30

Flag	Coverage Δ
integration1	`28.81% <4.00%> (-0.09%)`	⬇️
integration2	`27.48% <4.00%> (-0.22%)`	⬇️
unittests1	`67.37% <78.00%> (-0.51%)`	⬇️
unittests2	`14.09% <0.00%> (-0.09%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pinot-common/src/main/java/org/apache/pinot/common/request/context/RequestContextUtils.java

pinot-core/src/main/java/org/apache/pinot/core/operator/dociditerators/NotDocIdIterator.java

pinot-core/src/main/java/org/apache/pinot/core/operator/filter/FilterOperatorUtils.java

Jackie-Jiang · 2022-02-09T22:16:01Z

pinot-core/src/main/java/org/apache/pinot/core/operator/dociditerators/NotDocIdIterator.java

+ */
+public class NotDocIdIterator implements BlockDocIdIterator {
+  private BlockDocIdIterator _childDocIdIterator;
+  private int _lowerLimit;


Suggest renaming _lowerLimit to _nextDocId to be consistent with other iterators?

Jackie-Jiang · 2022-02-09T22:18:39Z

pinot-core/src/main/java/org/apache/pinot/core/operator/dociditerators/NotDocIdIterator.java

+public class NotDocIdIterator implements BlockDocIdIterator {
+  private BlockDocIdIterator _childDocIdIterator;
+  private int _lowerLimit;
+  private int _upperLimit;


Suggest renaming _upperLimit to _nextNonMatchingDocId

Jackie-Jiang · 2022-02-09T22:23:33Z

pinot-core/src/main/java/org/apache/pinot/core/operator/dociditerators/NotDocIdIterator.java

+
+  @Override
+  public int advance(int targetDocId) {
+    if (targetDocId == Constants.EOF || targetDocId > _numDocs) {


This can be simplified to:

_nextDocId = targetDocId; return next();

Not sure if that is valid -- doing that causes tests in NotDocIteratorTest to fail

Jackie-Jiang · 2022-02-09T22:24:14Z

pinot-core/src/main/java/org/apache/pinot/core/operator/dociditerators/NotDocIdIterator.java

+
+  @Override
+  public int next() {
+    while (_lowerLimit == _upperLimit) {


Change this to while (_lowerLimit >= _upperLimit), then both constructor and advance() can be simplified

I dont think that works -- since that can lead to skipping of the first docID (0) if that is a valid docID for the not iterator to return. Tests in NotDocIdIteratorTest highlight that.

Jackie-Jiang · 2022-02-09T22:24:52Z

pinot-core/src/main/java/org/apache/pinot/core/operator/dociditerators/NotDocIdIterator.java

+    _lowerLimit = 0;
+
+    int currentDocIdFromChildIterator = childDocIdIterator.next();
+    _upperLimit = currentDocIdFromChildIterator == Constants.EOF ? numDocs : currentDocIdFromChildIterator;


No need to initialize the upper limit here. The value check in next() should be able to handle that

That doesn't work, since it will lead to skipping the first document (i.e. not initialising upper limit implicitly implies that the first document is matching the inner iterator)

Jackie-Jiang · 2022-02-09T22:27:06Z

pinot-core/src/main/java/org/apache/pinot/core/operator/filter/NotFilterOperator.java

+    List<Operator> resultList = new ArrayList<>();
+    resultList.add(_filterOperator);
+
+    return resultList;


(minor)

Suggested change

List<Operator> resultList = new ArrayList<>();

resultList.add(_filterOperator);

return resultList;

return Collections.singletonList(_filterOperator);

Jackie-Jiang · 2022-02-15T00:20:26Z

...t-core/src/test/java/org/apache/pinot/core/operator/dociditerators/NotDocIdIteratorTest.java

+    bitmap3.add(docIds3);
+    MutableRoaringBitmap bitmap4 = new MutableRoaringBitmap();
+    bitmap4.add(docIds4);
+    OrDocIdIterator orDocIdIterator = new OrDocIdIterator(new BlockDocIdIterator[]{


Why do we need to build this OrDocIdIterator? We don't want to test OrDocIdIterator in this test

We use it to test NotDocIdIterator later in the test

Understood. What I'm saying is that we should directly set the docIds (similar to docIds1) instead of creating an OrDocIdIterator because that is more clear, and not mixing the scope of this test.

Jackie-Jiang · 2022-02-15T00:24:27Z

...t-core/src/test/java/org/apache/pinot/core/operator/dociditerators/NotDocIdIteratorTest.java

+    assertEquals(notDocIdIterator.advance(1), 2);
+    assertEquals(notDocIdIterator.next(), 3);
+    assertEquals(notDocIdIterator.next(), 5);
+    assertEquals(notDocIdIterator.advance(7), 8);


(major) Per the contract, this should return 7

The comment above advance() BlockDocIdIterator is a bit confusing. It says:

Returns the first matching document whose id is greater than or equal to the given target document id

I interpreted it as being ok if we return the first id greater than the target document id, which is what this test demonstrates. If that is not the case, should we reword the API spec to be explicit?

Fixed this issue, thanks for sharing the proposed solution!

Jackie-Jiang · 2022-02-15T00:25:11Z

...t-core/src/test/java/org/apache/pinot/core/operator/dociditerators/NotDocIdIteratorTest.java

+    assertEquals(notDocIdIterator.next(), 3);
+    assertEquals(notDocIdIterator.next(), 5);
+    assertEquals(notDocIdIterator.advance(7), 8);
+    assertEquals(notDocIdIterator.advance(13), 14);


(major) This should return 13, same for other places

Jackie-Jiang · 2022-02-15T00:27:35Z

pinot-core/src/main/java/org/apache/pinot/core/operator/dociditerators/NotDocIdIterator.java

+      return _nextDocId;
+    }
+
+    _nextDocId = targetDocId + 1;


(major) This will skip the targetDocId

Jackie-Jiang · 2022-02-15T00:29:35Z

pinot-core/src/main/java/org/apache/pinot/core/operator/dociditerators/NotDocIdIterator.java

+    if (targetDocId == Constants.EOF || targetDocId > _numDocs) {
+      return Constants.EOF;
+    }
+
+    if (targetDocId < _nextDocId) {
+      return _nextDocId;
+    }


These checks are redundant because by contract, targetDocId >= _nextDocId && targetDocId < _numDocs

Jackie-Jiang · 2022-02-15T00:30:35Z

pinot-core/src/main/java/org/apache/pinot/core/operator/dociditerators/NotDocIdIterator.java

+  }
+
+  private int findUpperLimitGreaterThanDocId(int currentDocId) {
+    int result = _childDocIdIterator.advance(currentDocId);


(major) need to check _nextNonMatchingDocId < currentDocId before advancing the pointer

Jackie-Jiang

LGTM with minor comments. Good job!

Jackie-Jiang · 2022-02-15T17:38:35Z

...t-core/src/test/java/org/apache/pinot/core/operator/dociditerators/NotDocIdIteratorTest.java

+    bitmap3.add(docIds3);
+    MutableRoaringBitmap bitmap4 = new MutableRoaringBitmap();
+    bitmap4.add(docIds4);
+    OrDocIdIterator orDocIdIterator = new OrDocIdIterator(new BlockDocIdIterator[]{


Understood. What I'm saying is that we should directly set the docIds (similar to docIds1) instead of creating an OrDocIdIterator because that is more clear, and not mixing the scope of this test.

Jackie-Jiang · 2022-02-15T17:40:22Z

pinot-core/src/test/java/org/apache/pinot/queries/NotOperatorQueriesTest.java

+
+  @Test
+  public void testWeirdPredicates() {
+    String query = "SELECT FIRST_INT_COL, SECOND_INT_COL FROM MyTable WHERE NOT FIRST_INT_COL = 5 LIMIT " + "50000";


(minor) Remove the unnecessary +, same for other places

Suggested change

String query = "SELECT FIRST_INT_COL, SECOND_INT_COL FROM MyTable WHERE NOT FIRST_INT_COL = 5 LIMIT " + "50000";

String query = "SELECT FIRST_INT_COL, SECOND_INT_COL FROM MyTable WHERE NOT FIRST_INT_COL = 5 LIMIT 50000";

Jackie-Jiang · 2022-02-15T17:42:52Z

pinot-core/src/main/java/org/apache/pinot/core/operator/filter/FilterOperatorUtils.java

          return 4;
        }
+        if (filterOperator instanceof NotFilterOperator) {
+          return getPriority((BaseFilterOperator) filterOperator.getChildOperators().get(0));


(minor) We can add a getChildFilterOperator() in NotFilterOperator which can save an unnecessary array allocation

ashishkf · 2022-02-20T05:54:08Z

When I tried the change from the controller UI, I got the following exception:

pinot-broker-2 broker 2022/02/20 05:46:39.065 ERROR [PinotClientRequest] [jersey-server-managed-async-executor-2] Caught exception while processing POST request
pinot-broker-2 broker java.lang.IndexOutOfBoundsException: Index 1 out of bounds for length 1
pinot-broker-2 broker at jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:64) ~[?:?]
pinot-broker-2 broker at jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:70) ~[?:?]
pinot-broker-2 broker at jdk.internal.util.Preconditions.checkIndex(Preconditions.java:248) ~[?:?]
pinot-broker-2 broker at java.util.Objects.checkIndex(Objects.java:372) ~[?:?]
pinot-broker-2 broker at java.util.ArrayList.get(ArrayList.java:459) ~[?:?]
pinot-broker-2 broker at org.apache.pinot.core.query.optimizer.filter.NumericalFilterOptimizer.optimize(NumericalFilterOptimizer.java:102) ~[pinot-all-0.9.0-jar-with-dependencies.jar:0.9.0-02f03f4a81d44564e818ceb720ba25e2ab31bc29]
pinot-broker-2 broker at org.apache.pinot.core.query.optimizer.QueryOptimizer.optimize(QueryOptimizer.java:81) ~[pinot-all-0.9.0-jar-with-dependencies.jar:0.9.0-02f03f4a81d44564e818ceb720ba25e2ab31bc29]
pinot-broker-2 broker at org.apache.pinot.broker.requesthandler.BaseBrokerRequestHandler.handleSQLRequest(BaseBrokerRequestHandler.java:381) ~[pinot-all-0.9.0-jar-with-dependencies.jar:0.9.0-02f03f4a81d44564e818ceb720ba25e2ab31bc29]
pinot-broker-2 broker at org.apache.pinot.broker.requesthandler.BaseBrokerRequestHandler.handleRequest(BaseBrokerRequestHandler.java:197) ~[pinot-all-0.9.0-jar-with-dependencies.jar:0.9.0-02f03f4a81d44564e818ceb720ba25e2ab31bc29]
pinot-broker-2 broker at org.apache.pinot.broker.requesthandler.BaseBrokerRequestHandler.handleRequest(BaseBrokerRequestHandler.java:102) ~[pinot-all-0.9.0-jar-with-dependencies.jar:0.9.0-02f03f4a81d44564e818ceb720ba25e2ab31bc29]
pinot-broker-2 broker at org.apache.pinot.broker.api.resources.PinotClientRequest.processSqlQueryPost(PinotClientRequest.java:191) ~[pinot-all-0.9.0-jar-with-dependencies.jar:0.9.0-02f03f4a81d44564e818ceb720ba25e2ab31bc29]
pinot-broker-2 broker at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
pinot-broker-2 broker at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:?]
pinot-broker-2 broker at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
pinot-broker-2 broker at java.lang.reflect.Method.invoke(Method.java:566) ~[?:?]
pinot-broker-2 broker at org.glassfish.jersey.server.model.internal.ResourceMethodInvocationHandlerFactory.lambda$static$0(ResourceMethodInvocationHandlerFactory.java:52) ~[pinot-all-0.9.0-jar-with-dependencies.jar:0.9.0-02f03f4a81d44564e818ceb720ba25e2ab31bc29]
pinot-broker-2 broker at org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher$1.run(AbstractJavaResourceMethodDispatcher.java:124) ~[pinot-all-0.9.0-jar-with-dependencies.jar:0.9.0-02f03f4a81d44564e818ceb720ba25e2ab31bc29]
pinot-broker-2 broker at org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher.invoke(AbstractJavaResourceMethodDispatcher.java:167) ~[pinot-all-0.9.0-jar-with-dependencies.jar:0.9.0-02f03f4a81d44564e818ceb720ba25e2ab31bc29]
pinot-broker-2 broker at org.glassfish.jersey.server.model.internal.JavaResourceMethodDispatcherProvider$VoidOutInvoker.doDispatch(JavaResourceMethodDispatcherProvider.java:159) ~[pinot-all-0.9.0-jar-with-dependencies.jar:0.9.0-02f03f4a81d44564e818ceb720ba25e2ab31bc29]
pinot-broker-2 broker at org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher.dispatch(AbstractJavaResourceMethodDispatcher.java:79) ~[pinot-all-0.9.0-jar-with-dependencies.jar:0.9.0-02f03f4a81d44564e818ceb720ba25e2ab31bc29]
pinot-broker-2 broker at org.glassfish.jersey.server.model.ResourceMethodInvoker.invoke(ResourceMethodInvoker.java:469) ~[pinot-all-0.9.0-jar-with-dependencies.jar:0.9.0-02f03f4a81d44564e818ceb720ba25e2ab31bc29]
pinot-broker-2 broker at org.glassfish.jersey.server.model.ResourceMethodInvoker.lambda$apply$0(ResourceMethodInvoker.java:381) ~[pinot-all-0.9.0-jar-with-dependencies.jar:0.9.0-02f03f4a81d44564e818ceb720ba25e2ab31bc29]
pinot-broker-2 broker at org.glassfish.jersey.server.ServerRuntime$AsyncResponder$2$1.run(ServerRuntime.java:819) [pinot-all-0.9.0-jar-with-dependencies.jar:0.9.0-02f03f4a81d44564e818ceb720ba25e2ab31bc29

]

atris · 2022-02-21T07:42:26Z

When I tried the change from the controller UI, I got the following exception:

pinot-broker-2 broker 2022/02/20 05:46:39.065 ERROR [PinotClientRequest] [jersey-server-managed-async-executor-2] Caught exception while processing POST request
pinot-broker-2 broker java.lang.IndexOutOfBoundsException: Index 1 out of bounds for length 1
pinot-broker-2 broker at jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:64) ~[?:?]
pinot-broker-2 broker at jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:70) ~[?:?]
pinot-broker-2 broker at jdk.internal.util.Preconditions.checkIndex(Preconditions.java:248) ~[?:?]
pinot-broker-2 broker at java.util.Objects.checkIndex(Objects.java:372) ~[?:?]
pinot-broker-2 broker at java.util.ArrayList.get(ArrayList.java:459) ~[?:?]
pinot-broker-2 broker at org.apache.pinot.core.query.optimizer.filter.NumericalFilterOptimizer.optimize(NumericalFilterOptimizer.java:102) ~[pinot-all-0.9.0-jar-with-dependencies.jar:0.9.0-02f03f4a81d44564e818ceb720ba25e2ab31bc29]
pinot-broker-2 broker at org.apache.pinot.core.query.optimizer.QueryOptimizer.optimize(QueryOptimizer.java:81) ~[pinot-all-0.9.0-jar-with-dependencies.jar:0.9.0-02f03f4a81d44564e818ceb720ba25e2ab31bc29]
pinot-broker-2 broker at org.apache.pinot.broker.requesthandler.BaseBrokerRequestHandler.handleSQLRequest(BaseBrokerRequestHandler.java:381) ~[pinot-all-0.9.0-jar-with-dependencies.jar:0.9.0-02f03f4a81d44564e818ceb720ba25e2ab31bc29]
pinot-broker-2 broker at org.apache.pinot.broker.requesthandler.BaseBrokerRequestHandler.handleRequest(BaseBrokerRequestHandler.java:197) ~[pinot-all-0.9.0-jar-with-dependencies.jar:0.9.0-02f03f4a81d44564e818ceb720ba25e2ab31bc29]
pinot-broker-2 broker at org.apache.pinot.broker.requesthandler.BaseBrokerRequestHandler.handleRequest(BaseBrokerRequestHandler.java:102) ~[pinot-all-0.9.0-jar-with-dependencies.jar:0.9.0-02f03f4a81d44564e818ceb720ba25e2ab31bc29]
pinot-broker-2 broker at org.apache.pinot.broker.api.resources.PinotClientRequest.processSqlQueryPost(PinotClientRequest.java:191) ~[pinot-all-0.9.0-jar-with-dependencies.jar:0.9.0-02f03f4a81d44564e818ceb720ba25e2ab31bc29]
pinot-broker-2 broker at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
pinot-broker-2 broker at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:?]
pinot-broker-2 broker at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
pinot-broker-2 broker at java.lang.reflect.Method.invoke(Method.java:566) ~[?:?]
pinot-broker-2 broker at org.glassfish.jersey.server.model.internal.ResourceMethodInvocationHandlerFactory.lambda$static$0(ResourceMethodInvocationHandlerFactory.java:52) ~[pinot-all-0.9.0-jar-with-dependencies.jar:0.9.0-02f03f4a81d44564e818ceb720ba25e2ab31bc29]
pinot-broker-2 broker at org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher$1.run(AbstractJavaResourceMethodDispatcher.java:124) ~[pinot-all-0.9.0-jar-with-dependencies.jar:0.9.0-02f03f4a81d44564e818ceb720ba25e2ab31bc29]
pinot-broker-2 broker at org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher.invoke(AbstractJavaResourceMethodDispatcher.java:167) ~[pinot-all-0.9.0-jar-with-dependencies.jar:0.9.0-02f03f4a81d44564e818ceb720ba25e2ab31bc29]
pinot-broker-2 broker at org.glassfish.jersey.server.model.internal.JavaResourceMethodDispatcherProvider$VoidOutInvoker.doDispatch(JavaResourceMethodDispatcherProvider.java:159) ~[pinot-all-0.9.0-jar-with-dependencies.jar:0.9.0-02f03f4a81d44564e818ceb720ba25e2ab31bc29]
pinot-broker-2 broker at org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher.dispatch(AbstractJavaResourceMethodDispatcher.java:79) ~[pinot-all-0.9.0-jar-with-dependencies.jar:0.9.0-02f03f4a81d44564e818ceb720ba25e2ab31bc29]
pinot-broker-2 broker at org.glassfish.jersey.server.model.ResourceMethodInvoker.invoke(ResourceMethodInvoker.java:469) ~[pinot-all-0.9.0-jar-with-dependencies.jar:0.9.0-02f03f4a81d44564e818ceb720ba25e2ab31bc29]
pinot-broker-2 broker at org.glassfish.jersey.server.model.ResourceMethodInvoker.lambda$apply$0(ResourceMethodInvoker.java:381) ~[pinot-all-0.9.0-jar-with-dependencies.jar:0.9.0-02f03f4a81d44564e818ceb720ba25e2ab31bc29]
pinot-broker-2 broker at org.glassfish.jersey.server.ServerRuntime$AsyncResponder$2$1.run(ServerRuntime.java:819) [pinot-all-0.9.0-jar-with-dependencies.jar:0.9.0-02f03f4a81d44564e818ceb720ba25e2ab31bc29

]

Thanks for trying it out. Can you check with the latest commit?

This PR implements the NOT operator. NOT operator is implemented in a generic manner i.e. it can support most underlying operators. The operator operates by "skipping" documents that are valid for the underlying predicate and iterating over all other valid docIDs. Support for LIKE operator is not present yet due to Calcite's slightly different parsing of the LIKE operator.

Jackie-Jiang · 2022-03-10T00:57:45Z

@atris This is a great feature. Could you please add some release notes to the PR description which we can refer to when cutting the next release?

atris added 5 commits February 1, 2022 17:00

Initial Commit

a678880

Firsr version working

934e246

More stuff

1e97cf0

Working version 1

5c198aa

Change List.of to use proper list creation

0ba25de

atris mentioned this pull request Feb 7, 2022

Support NOT operator #7701

Closed

Merge remote-tracking branch 'main_origin/master' into not_filter_impl

9d299b3

Jackie-Jiang reviewed Feb 9, 2022

View reviewed changes

atris added 2 commits February 14, 2022 14:23

Fix per comments

9a0885b

Fix linter

90ab312

Jackie-Jiang reviewed Feb 15, 2022

View reviewed changes

Refactor

6b64946

Jackie-Jiang approved these changes Feb 15, 2022

View reviewed changes

Fix bug and fix comments

bcb3886

atris merged commit 3168194 into apache:master Feb 21, 2022

Jackie-Jiang added feature release-notes Referenced by PRs that need attention when compiling the next release notes labels Mar 10, 2022

	String query = "SELECT FIRST_INT_COL, SECOND_INT_COL FROM MyTable WHERE NOT FIRST_INT_COL = 5 LIMIT " + "50000";
	String query = "SELECT FIRST_INT_COL, SECOND_INT_COL FROM MyTable WHERE NOT FIRST_INT_COL = 5 LIMIT 50000";

Implement NOT Operator #8148

Implement NOT Operator #8148

Uh oh!

Conversation

atris commented Feb 7, 2022

Uh oh!

siddharthteotia commented Feb 7, 2022

Uh oh!

codecov-commenter commented Feb 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Jackie-Jiang left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ashishkf commented Feb 20, 2022

Uh oh!

atris commented Feb 21, 2022

Uh oh!

Jackie-Jiang commented Mar 10, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov-commenter commented Feb 9, 2022 •

edited

Loading