Skip to content

Conversation

@snleee
Copy link
Contributor

@snleee snleee commented Feb 4, 2022

Currently, the progress reporter only runs during the segment
creation phase. We stop the reporter; however, it is possible
that the tarring & copying from local to remote location for
large file can take long. This code change makes the progress
reporter runs until the end of map() in SegmentCreationMapper.

@snleee snleee force-pushed the improve-progress-report branch from 80638de to 1c3a2dd Compare February 4, 2022 09:18
Copy link
Member

@jackjlli jackjlli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Currently, the progress reporter only runs during the segment
creation phase. We stop the reporter; however, it is possible
that the tarring & copying from local to remote location for
large file can take long. This code change makes the progress
reporter runs until the end of `map()` in SegmentCreationMapper.
@snleee snleee force-pushed the improve-progress-report branch from 1c3a2dd to 91c80a6 Compare February 4, 2022 22:08
@snleee snleee merged commit 8bbf93a into apache:master Feb 5, 2022
@snleee snleee deleted the improve-progress-report branch February 5, 2022 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants