Skip to content

fix: Can not open new tabs from Pinot Dashboard #8021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mayankshriv merged 1 commit into from
Jan 14, 2022
Merged

fix: Can not open new tabs from Pinot Dashboard #8021

mayankshriv merged 1 commit into from
Jan 14, 2022

Conversation

@shahsank3t
Copy link
Contributor

@shahsank3t shahsank3t commented Jan 14, 2022

Description

This PR fixes #8000
Attaching screenshot for the reference:
image
image

@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2022 •
edited
Loading

Codecov Report

Merging #8021 (5d6325c) into master (ca08968) will decrease coverage by 3.18%.
The diff coverage is n/a.

❗ Current head 5d6325c differs from pull request most recent head bb16209. Consider uploading reports for the commit bb16209 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8021      +/-   ##
============================================
- Coverage     71.36%   68.18%   -3.19%     
+ Complexity     4226     4143      -83     
============================================
  Files          1596     1201     -395     
  Lines         82871    60064   -22807     
  Branches      12363     9256    -3107     
============================================
- Hits          59144    40956   -18188     
+ Misses        19728    16226    -3502     
+ Partials       3999     2882    -1117
Flag Coverage Δ
integration1 ?
integration2 ?
unittests1 68.18% <ø> (-0.01%) ⬇️
unittests2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...a/org/apache/pinot/common/metrics/MinionMeter.java 0.00% <0.00%> (-100.00%) ⬇️
...g/apache/pinot/common/metrics/ControllerMeter.java 0.00% <0.00%> (-100.00%) ⬇️
.../apache/pinot/common/metrics/BrokerQueryPhase.java 0.00% <0.00%> (-100.00%) ⬇️
.../apache/pinot/common/metrics/MinionQueryPhase.java 0.00% <0.00%> (-100.00%) ⬇️
...he/pinot/common/messages/SegmentReloadMessage.java 0.00% <0.00%> (-100.00%) ⬇️
...pinot/core/data/manager/realtime/TimerService.java 0.00% <0.00%> (-100.00%) ⬇️
...not/common/exception/HttpErrorStatusException.java 0.00% <0.00%> (-100.00%) ⬇️
...t/core/plan/StreamingInstanceResponsePlanNode.java 0.00% <0.00%> (-100.00%) ⬇️
...t/core/startree/plan/StarTreeDocIdSetPlanNode.java 0.00% <0.00%> (-100.00%) ⬇️
...ot/common/restlet/resources/TableMetadataInfo.java 0.00% <0.00%> (-100.00%) ⬇️
... and 608 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca08968...bb16209. Read the comment docs.

@mayankshriv mayankshriv merged commit f85a3df into apache:master Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mayankshriv mayankshriv mayankshriv approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Can not open new tabs from Pinot Dashboard

3 participants

@shahsank3t @codecov-commenter @mayankshriv