make query stats always show even there's error #7981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7981 +/- ##
============================================
- Coverage 71.27% 64.03% -7.25%
+ Complexity 4218 4132 -86
============================================
Files 1595 1586 -9
Lines 82723 82377 -346
Branches 12342 12305 -37
============================================
- Hits 58959 52746 -6213
- Misses 19779 25860 +6081
+ Partials 3985 3771 -214
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
joshigaurava
reviewed
Jan 7, 2022
pinot-controller/src/main/resources/app/utils/PinotMethodUtils.ts
Outdated
Show resolved
Hide resolved
joshigaurava
reviewed
Jan 7, 2022
walterddr
force-pushed
the
broker_response_fix
branch
from
80ac566 to
2385201
Compare
Contributor
|
Looks good. 👍 |
siddharthteotia
approved these changes
Jan 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the issue that currently if there's an error in the result, query stats are not shown on UI.
this is particularly useful when partial response was sent back from the server, it will at least give broker level metrics for diagnosis
before:
after:
