exit group-by marking loop early #7935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7935 +/- ##
============================================
+ Coverage 71.15% 71.17% +0.01%
+ Complexity 4111 4106 -5
============================================
Files 1593 1593
Lines 82365 82373 +8
Branches 12270 12269 -1
============================================
+ Hits 58609 58627 +18
+ Misses 19806 19798 -8
+ Partials 3950 3948 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
...n/java/org/apache/pinot/core/query/aggregation/groupby/DictionaryBasedGroupKeyGenerator.java
Outdated
Show resolved
Hide resolved
Jackie-Jiang
approved these changes
Dec 21, 2021
...n/java/org/apache/pinot/core/query/aggregation/groupby/DictionaryBasedGroupKeyGenerator.java
Outdated
Show resolved
Hide resolved
richardstartin
force-pushed
the
groupby-exit-early
branch
from
3399b72 to
08e20f5
Compare
siddharthteotia
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For low cardinality one dimensional group by queries, it's possible to exit the group marking loop much earlier than the 10k default block size.