Skip to content

Add TIMESTAMP to datetime column Type #7746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Jackie-Jiang merged 1 commit into from
Nov 11, 2021
Merged

Add TIMESTAMP to datetime column Type #7746

Jackie-Jiang merged 1 commit into from
Nov 11, 2021

Conversation

@shahsank3t
Copy link
Contributor

@shahsank3t shahsank3t commented Nov 11, 2021 •
edited
Loading

Description

This PR fixes #7745
image

@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2021

Codecov Report

Merging #7746 (141f627) into master (af01aa5) will decrease coverage by 49.68%.
The diff coverage is n/a.

❗ Current head 141f627 differs from pull request most recent head 4597b27. Consider uploading reports for the commit 4597b27 to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##             master    #7746       +/-   ##
=============================================
- Coverage     64.23%   14.54%   -49.69%     
+ Complexity     3985       80     -3905     
=============================================
  Files          1568     1531       -37     
  Lines         80194    78675     -1519     
  Branches      11929    11765      -164     
=============================================
- Hits          51510    11444    -40066     
- Misses        25022    66395    +41373     
+ Partials       3662      836     -2826
Flag Coverage Δ
integration1 ?
integration2 ?
unittests1 ?
unittests2 14.54% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ain/java/org/apache/pinot/core/data/table/Key.java 0.00% <0.00%> (-100.00%) ⬇️
.../java/org/apache/pinot/spi/utils/BooleanUtils.java 0.00% <0.00%> (-100.00%) ⬇️
.../java/org/apache/pinot/core/data/table/Record.java 0.00% <0.00%> (-100.00%) ⬇️
.../java/org/apache/pinot/core/util/GroupByUtils.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/data/MetricFieldSpec.java 0.00% <0.00%> (-100.00%) ⬇️
...va/org/apache/pinot/spi/utils/BigDecimalUtils.java 0.00% <0.00%> (-100.00%) ⬇️
...java/org/apache/pinot/common/tier/TierFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...java/org/apache/pinot/common/utils/StringUtil.java 0.00% <0.00%> (-100.00%) ⬇️
...va/org/apache/pinot/core/data/table/BaseTable.java 0.00% <0.00%> (-100.00%) ⬇️
...a/org/apache/pinot/spi/config/table/TableType.java 0.00% <0.00%> (-100.00%) ⬇️
... and 1403 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af01aa5...4597b27. Read the comment docs.

Jackie-Jiang
Jackie-Jiang approved these changes Nov 11, 2021
View reviewed changes
Copy link
Contributor

@Jackie-Jiang Jackie-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Jackie-Jiang Jackie-Jiang merged commit 94d3c5f into apache:master Nov 11, 2021
kriti-sc pushed a commit to kriti-sc/incubator-pinot that referenced this pull request Dec 12, 2021
@shahsank3t @kriti-sc
Add TIMESTAMP to datetime column Type (apache#7746)
c84998e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jackie-Jiang Jackie-Jiang Jackie-Jiang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add TIMESTAMP to datetime column Type

3 participants

@shahsank3t @codecov-commenter @Jackie-Jiang