add method to get column indices created in segment folder #7297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov Report
@@ Coverage Diff @@
## master #7297 +/- ##
=============================================
- Coverage 71.31% 14.63% -56.68%
+ Complexity 3361 92 -3269
=============================================
Files 1503 1457 -46
Lines 73995 72100 -1895
Branches 10709 10510 -199
=============================================
- Hits 52766 10550 -42216
- Misses 17627 60784 +43157
+ Partials 3602 766 -2836
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
klsince
force-pushed
the
get_column_indices
branch
from
357022a to
017b9be
Compare
...-local/src/main/java/org/apache/pinot/segment/local/segment/store/FilePerIndexDirectory.java
Outdated
Show resolved
Hide resolved
...-local/src/main/java/org/apache/pinot/segment/local/segment/store/FilePerIndexDirectory.java
Outdated
Show resolved
Hide resolved
...cal/src/main/java/org/apache/pinot/segment/local/segment/store/SingleFileIndexDirectory.java
Outdated
Show resolved
Hide resolved
added 2 commits
August 13, 2021 12:21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This method expose the column indices created in local segment folder, which can be compared with indices in table config to decide which indices to remove as to be implemented in #7286.
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
backward-incompat, and complete the section below on Release Notes)Does this PR fix a zero-downtime upgrade introduced earlier?
backward-incompat, and complete the section below on Release Notes)Does this PR otherwise need attention when creating release notes? Things to consider:
release-notesand complete the section on Release Notes)Release Notes
Documentation