sanity check: is this the format the back end will send this? no camelCase? metricAnomalyId

Ah darn. I did a replace all for Id:..with anomalyId. Need to revert.

DONE

nit: could use .mapBy('name') here

example:

import EmberObject from '@ember/object';

let hawaii = EmberObject.create({
  capital: 'Honolulu'
});

let california = EmberObject.create({
  capital: 'Sacramento'
});

let states = [hawaii, california];

states.mapBy('capital')

documentation:

https://guides.emberjs.com/v2.18.0/object-model/enumerables/#toc_map

DONE

nit: let's use async/await to avoid the nested then's?

Ok cool. It was copied of existing codes didn't check to refractor the method itself. I can do it now.

@aaronucsd ah didn't realize this was a copy/pasta. a TODO comment in the code is fine for now 👍

DONE

fyi, We could leverage getWithDefault here:

documentation:

https://emberjs.com/api/ember/2.18/functions/@ember%2Fobject/getWithDefault

example:

import { getWithDefault } from '@ember/object';
// ....
const filterMap = getWithDefault(res, 'searchFilters. statusFilterMap', null);

Sure. But i don't see why we need invoke a method that does the same kind of ternary underneath. I like it this way, it's more explicit to read.

DONE

if anomalyRecord is an ember object (it should be),

we can utilize setProperties so that we don't notify property changes for each sets. An alternative would be to wrap that in an ember run.

documentation:

https://emberjs.com/api/ember/2.18/functions/@ember%2Fobject/setProperties

example:

anomalyRecord.setProperties({
  anomalyFeedback: selectedResponse,
  showResponseSaved: true
})

again existing codes. But updated. Thanks.

DONE

let's use setProperties here

again existing codes. But updated. Thanks.

DONE

nit: if we're sure that range contains both name and value property, we could deconstruct it

({ name, value }) => {
 // ...
  return {
       name,
       value,
       isActive: false
    };
 // ...
}

i'm not sure on this code. It existing and shows green because of merge conflict resolved.

SKIPPED

👍 fyi, I believe Steve started an API file, we can start thinking about putting new urls there in an effort to alleviate new tech debt

He has it for self-serve only. I can put another one for maybe something general.

app/utils/api/self-serve.js

added utils/api/anomaly.js. DONE

Just curious what's the rationale behind choosing to implement it as a utils vs a service?

https://guides.emberjs.com/v3.0.0/applications/services/ explains the criteria for when to create a service. THere is no need to require shared state etc here.

DONE

The jsDoc here doesn't seem to match the component.

done

Every new line above 435 should be removed (merge resolution fix)

DONE

onRangeOptionClick no longer needed.

removed.

DONE

You can restore onRangeSelection

DONE

Lets try import { anomalyResponseObj } from 'thirdeye-frontend/utils/anomaly';

DONE

Not needed, right?

yep. Let me remove.

Nice - thank you!