Enhance QueryRunner to support single thread, multi threads and target QPS modes. #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 45.85%@@ master #254 diff @@
==========================================
Files 696 696
Lines 32113 32178 +65
Methods 0 0
Messages 0 0
Branches 4815 4823 +8
==========================================
+ Hits 14727 14754 +27
- Misses 16210 16246 +36
- Partials 1176 1178 +2
|
Contributor
There was a problem hiding this comment.
Not a requirement for this commit, but you may want to consider adding checks like mutually exclusive arguments, dependent arguments etc.
Contributor
|
LGTM, other than the comments. |
Jackie-Jiang
force-pushed
the
enhance_query_runner
branch
from
4bb7ddf to
3d57064
Compare
ege-st
pushed a commit
to ege-st/pinot
that referenced
this pull request
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.