Skip to content

Conversation

@kdemarest
Copy link
Contributor

BTW, can I email you and ask a few questions about how hard it might be to put Mesos under PInot instead of Helix?

dhaval2025 added a commit that referenced this pull request Jun 10, 2015
Comment typo in last SQL example.
@dhaval2025 dhaval2025 merged commit 8a2c725 into apache:master Jun 10, 2015
aaronucsd pushed a commit to aaronucsd/pinot that referenced this pull request Mar 19, 2018
1. Added new resolution custom component
2. fixed the icon issue on resolution select for model table
3. Updated styling for the fix in apache#2
4. Added new method to anomaly util file and moved a few needed anomaly methods from
app/pods/manage/alert/explore/controller.js
5. Moved anomalyResponseObj constant to anomaly util from
app/pods/manage/alert/explore/route.js
6. Updated app/pods/manage/alert/explore/* to use the methods from anomaly util
7. updated anomaly util unit test and ran all tests for sanity
8. Added new api anomaly file and unit test
aaronucsd pushed a commit that referenced this pull request Mar 19, 2018
…2634)

1. Added new resolution custom component
2. fixed the icon issue on resolution select for model table
3. Updated styling for the fix in #2
4. Added new method to anomaly util file and moved a few needed anomaly methods from
app/pods/manage/alert/explore/controller.js
5. Moved anomalyResponseObj constant to anomaly util from
app/pods/manage/alert/explore/route.js
6. Updated app/pods/manage/alert/explore/* to use the methods from anomaly util
7. updated anomaly util unit test and ran all tests for sanity
8. Added new api anomaly file and unit test
npawar pushed a commit that referenced this pull request Apr 6, 2018
…2634)

1. Added new resolution custom component
2. fixed the icon issue on resolution select for model table
3. Updated styling for the fix in #2
4. Added new method to anomaly util file and moved a few needed anomaly methods from
app/pods/manage/alert/explore/controller.js
5. Moved anomalyResponseObj constant to anomaly util from
app/pods/manage/alert/explore/route.js
6. Updated app/pods/manage/alert/explore/* to use the methods from anomaly util
7. updated anomaly util unit test and ran all tests for sanity
8. Added new api anomaly file and unit test
xiangfu0 added a commit that referenced this pull request Jun 13, 2019
* Adding script to build and publish docker image (#2)

* Address comments

* Adding license header

* Adding thrift support in build image

* update readme
xxsacxx pushed a commit to xxsacxx/incubator-pinot that referenced this pull request Apr 3, 2020
kmozaid referenced this pull request in kmozaid/pinot Feb 17, 2022
Add controller.dimTable.maxSize to ALL Pinot Cluster
zeronerdzerogeekzerocool pushed a commit to zeronerdzerogeekzerocool/pinot that referenced this pull request Feb 20, 2025
matvj250 referenced this pull request in matvj250/pinot Apr 22, 2025
matvj250 referenced this pull request in matvj250/pinot Apr 22, 2025
This reverts commit 270937f.
siddharthteotia pushed a commit that referenced this pull request May 2, 2025
* Addition of initial spi change checker code

* Fixes to yaml file, mainly excluding artifacts.zip code to test run further

* changing shell file permissions

* add "exit 1" to shell script and mess with TableConfig method signature

* changing shell file permissions again for some reason

* changing git diff checker file path

* second git diff checker file path change

* removing unnecessary code from files, fixed issue with running GitDiffChecker, added functionality for displaying line number, and reverted temporary change to TableConfig.java

* permission changes

* changing permissions

* fixing compilation error

* fixing parameterization of commits

* trial and error yml file #1

* commit for testing that config file correctly has parameters, changing sh file so that "No incorrect..." message only displayed once, and adding blank line check to GitDiffChecker

* GitDiffChecker: add case to skip ---. otherwise, change parameters to work with pull requests.

* testing

* testing #2

* Revert "testing #2"

This reverts commit 270937f.

* yml: change main to master. shell: change main to master and change conditional to reflect return type change. java: switch from returning line number to string of code, as previous logic did not work if multiple "chunks" of code were changed, and added annotation logic that excluded json-related annotations.

* yml: comment out apache/pinot condition for now. shell: change error message and put text file in my module. java: slightly altered regex after rethinking it, removed System.out.println, i think it's not necessary

* java: slightly altered regex to account for interface definitions using semicolons and not curly braces

* changing "no incorrect spi changes" value to "0", so if the method returns nothing, there isn't an accidental test passing

* minor change to annotation regex, \n changed to $ (end of string)

* fix to pom.xml

* Added logic for outputting line number along with original file code snippet

* per testing on another branch, slightly updating line number logic

* Removed my outdated custom Java implementation of pinot-spi change checking. Switched to the japicmp plugin, with some modifications to the compatibility of checks that japicmp performs. With this, contributors will be able to see if they made incompatible SPI changes when running mvn clean, rather than waiting until they make a PR. Adding a .jar of pinot-spi that japicmp will use for comparisons.

* Per Tianle's comment, added a comment in the pom file explaining our justification for using a baseline jar for comparison, and that we need to eventually transition away from it.

* Removed code that made annotation changes/deletions incompatible. Fixed pom file so that all pinot-spi files are checked

* updated baseline .jar to match updates from apache:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants