[timeseries] Decouple query dispatcher #17474
Merged
+133
−111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackie-Jiang
added
bugfix
refactor
timeseries-engine
Contributor
There was a problem hiding this comment.
Pull request overview
This PR decouples the time-series query dispatcher from the multi-stage query dispatcher, creating a dedicated TimeSeriesQueryDispatcher class with its own lifecycle management. The change removes shared functionality that wasn't actually being used between the two dispatchers and fixes a channel cleanup bug.
Key changes:
- Moved time-series dispatch logic into a new dedicated
TimeSeriesQueryDispatcherclass - Fixed channel resource leak by implementing proper shutdown logic in the new dispatcher
- Removed time-series dependencies from
QueryDispatcherto simplify the multi-stage query dispatcher
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| TimeSeriesQueryDispatcher.java | New dedicated dispatcher for time-series queries with channel lifecycle management |
| QueryDispatcher.java | Removed time-series dispatch logic and related dependencies |
| TimeSeriesRequestHandler.java | Updated to use the new TimeSeriesQueryDispatcher directly |
| BaseBrokerStarter.java | Removed QueryDispatcher creation that was only needed for time-series queries |
| QueryDispatcherTest.java | Updated test to pass new required Duration parameter |
.../main/java/org/apache/pinot/query/service/dispatch/timeseries/TimeSeriesQueryDispatcher.java
Show resolved
Hide resolved
.../main/java/org/apache/pinot/query/service/dispatch/timeseries/TimeSeriesQueryDispatcher.java
Show resolved
Hide resolved
.../main/java/org/apache/pinot/query/service/dispatch/timeseries/TimeSeriesQueryDispatcher.java
Show resolved
Hide resolved
.../main/java/org/apache/pinot/query/service/dispatch/timeseries/TimeSeriesQueryDispatcher.java
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #17474 +/- ##
============================================
- Coverage 63.30% 63.30% -0.01%
Complexity 1476 1476
============================================
Files 3163 3164 +1
Lines 188817 188815 -2
Branches 28899 28899
============================================
- Hits 119532 119529 -3
+ Misses 60019 60016 -3
- Partials 9266 9270 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Jackie-Jiang
force-pushed
the
decouple_time_series_query_dispatcher
branch
from
dfc7010 to
267ac99
Compare
ankitsultana
approved these changes
Jan 8, 2026
shauryachats
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TimeSeriesDispatchClient