[multistage] Add broker config defaults for physical optimizer and lite mode settings #16240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shauryachats
changed the title
ankitsultana
changed the title
ankitsultana
added
multi-stage
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java
Outdated
Show resolved
Hide resolved
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java
Outdated
Show resolved
Hide resolved
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #16240 +/- ##
============================================
+ Coverage 62.90% 63.19% +0.28%
+ Complexity 1386 1362 -24
============================================
Files 2867 2960 +93
Lines 163354 171029 +7675
Branches 24952 26179 +1227
============================================
+ Hits 102755 108078 +5323
- Misses 52847 54767 +1920
- Partials 7752 8184 +432
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ankitsultana
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for setting default values for several query execution options at the broker level, including:
usePhysicalOptimizeruseLiteModerunInBrokeruseBrokerPruningliteModeServerStageLimitThese values are now configurable via
pinot-broker.confand can still be overridden per query. The changes ensure consistent behavior across components likeQueryEnvironmentandPhysicalPlannerContext, replacing hardcoded defaults with configurable ones.