Modify parser to support type aliases like LONG for BIGINT in MSE #15615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashmayya
added
enhancement
user-experience
yashmayya
force-pushed
the
type-aliases-mse
branch
2 times, most recently
from
0a373fd to
affda21
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #15615 +/- ##
============================================
+ Coverage 62.75% 62.85% +0.10%
Complexity 1384 1384
============================================
Files 2864 2864
Lines 162727 162736 +9
Branches 24916 24916
============================================
+ Hits 102121 102294 +173
+ Misses 52898 52728 -170
- Partials 7708 7714 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yashmayya
force-pushed
the
type-aliases-mse
branch
from
affda21 to
e636449
Compare
yashmayya
force-pushed
the
type-aliases-mse
branch
from
e636449 to
73b157f
Compare
xiangfu0
approved these changes
Apr 27, 2025
gortiz
approved these changes
Apr 28, 2025
gortiz
added
the
release-notes
yashmayya
added
the
upgrade-incompat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BIG_DECIMALforDECIMALBYTESforVARBINARYLONGforBIGINTSTRINGforVARCHARBIGINT,VARBINARY,VARCHARaren't actual Pinot types - they're Calcite SQL types that map to Pinot types (https://docs.pinot.apache.org/configuration-reference/schema#data-types) and usages in functions likeCASTare the only place they're exposed to users.CAST(intCol AS BIGINT)(and all the other aliases).