Skip to content

[PoC] Physical Optimizer in MSE #15282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ankitsultana wants to merge 7 commits into from
Closed

[PoC] Physical Optimizer in MSE #15282

ankitsultana wants to merge 7 commits into from

Conversation

@ankitsultana
Copy link
Contributor

@ankitsultana ankitsultana commented Mar 14, 2025 •
edited
Loading

More details to be shared by March 18.

TODO (left for proper PRs):

  • stage parallelism
  • partition parallelism
  • lookup join
  • move dynamic filter to physical

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 2.34584% with 1457 lines in your changes missing coverage. Please review.

Project coverage is 33.89%. Comparing base (59551e4) to head (afd5578).
Report is 2252 commits behind head on master.

Files with missing lines Patch % Lines
...ysical/v2/rules/LeafStageWorkerAssignmentRule.java 0.00% 190 Missing ⚠️
...hysical/v2/rules/WorkerExchangeAssignmentRule.java 0.00% 178 Missing ⚠️
...y/planner/physical/v2/PRelToPlanNodeConverter.java 0.00% 164 Missing ⚠️
...ner/physical/PlanFragmentAndMailboxAssignment.java 0.00% 146 Missing ⚠️
...anner/physical/v2/rules/AggregatePushdownRule.java 0.00% 130 Missing ⚠️
...a/org/apache/pinot/query/planner/TraitShuttle.java 0.00% 101 Missing ⚠️
...t/calcite/rel/rules/PinotLogicalAggregateRule.java 8.91% 92 Missing ⚠️
...he/pinot/query/planner/physical/v2/MappingGen.java 0.00% 70 Missing ⚠️
...pache/pinot/calcite/rel/PinotDataDistribution.java 0.00% 60 Missing ⚠️
...ache/pinot/query/planner/physical/v2/PRelNode.java 0.00% 53 Missing ⚠️
... and 25 more

❗ There is a different number of reports uploaded between BASE (59551e4) and HEAD (afd5578). Click for more details.

HEAD has 10 uploads less than BASE
Flag BASE (59551e4) HEAD (afd5578)
temurin 12 10
java-21 7 6
skip-bytebuffers-false 7 5
unittests 5 3
unittests1 2 0
java-11 5 4
Additional details and impacted files 
@@              Coverage Diff              @@
##             master   #15282       +/-   ##
=============================================
- Coverage     61.75%   33.89%   -27.86%     
- Complexity      207      690      +483     
=============================================
  Files          2436     2803      +367     
  Lines        133233   157817    +24584     
  Branches      20636    24276     +3640     
=============================================
- Hits          82274    53490    -28784     
- Misses        44911   100051    +55140     
+ Partials       6048     4276     -1772
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 33.88% <2.34%> (-27.83%) ⬇️
java-21 33.89% <2.34%> (-27.74%) ⬇️
skip-bytebuffers-false 33.89% <2.34%> (-27.86%) ⬇️
skip-bytebuffers-true 33.88% <2.34%> (+6.16%) ⬆️
temurin 33.89% <2.34%> (-27.86%) ⬇️
unittests 33.88% <2.34%> (-27.86%) ⬇️
unittests1 ?
unittests2 33.88% <2.34%> (+6.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ankitsultana ankitsultana mentioned this pull request Mar 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ankitsultana @codecov-commenter