Spool4 #14672
Open
Spool4 #14672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rename some test methods Co-authored-by: Yash Mayya <[email protected]>
Explain implementation is working, but not actual queries.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14672 +/- ##
============================================
+ Coverage 61.75% 64.02% +2.27%
- Complexity 207 1603 +1396
============================================
Files 2436 2705 +269
Lines 133233 149091 +15858
Branches 20636 22844 +2208
============================================
+ Hits 82274 95453 +13179
- Misses 44911 46637 +1726
- Partials 6048 7001 +953
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation (and should be merged after) of #14507 and the next step on #14196.
Here we introduce a new exchange that buffers data on the heap. This is a cheap implementation. In future we may decide add an offheap implementation.