Improve performance of multi-stage queries with large IN clauses #14615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14615 +/- ##
============================================
+ Coverage 61.75% 63.61% +1.86%
- Complexity 207 1461 +1254
============================================
Files 2436 2772 +336
Lines 133233 156247 +23014
Branches 20636 23981 +3345
============================================
+ Hits 82274 99404 +17130
- Misses 44911 49355 +4444
- Partials 6048 7488 +1440
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yashmayya
force-pushed
the
optimize-large-in-clauses
branch
from
037795c to
50c41d1
Compare
gortiz
approved these changes
Mar 11, 2025
yashmayya
added a commit
to yashmayya/pinot
that referenced
this pull request
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CoreRules.FILTER_REDUCE_EXPRESSIONSfrom huge number of filter predicates created byPinotFilterExpandSearchRule(IN->OR, see Multi-stage: Perf issue when IN expression has a lot of entries #13617).SqlToRelConverterwhere we're convertingINtoORno matter the size of theINlist (see discussion in https://issues.apache.org/jira/browse/CALCITE-6467). The default Calcite threshold is 20 beyond which theINis converted to a join with a static table; however, this causes query execution overhead for us since we aren't currently optimizing such joins and might need to pay unnecessary data shuffling cost.SqlToRelConverterpart of the inefficiency will be fixed by upgrading Calcite to 1.39.0 which is due to be released soon.PinotFilterExpandSearchRulebecause we already have logic in theRelNode->PlanNodeconversion phase that safely converts theSEARCHoperators without the risk of incurring optimization overhead from other rules due to the conversion to a bunch of OR'd = expressions (we convert directly toIN/NOT INinstead). The logic has been updated to also be able to handle literal onlySEARCHexpressions that can be generated by Calcite'sFILTER_REDUCE_EXPRESSIONSrule.