Override return type for NOW to TIMESTAMP in the v2 engine #14614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14614 +/- ##
============================================
+ Coverage 61.75% 64.03% +2.28%
- Complexity 207 1573 +1366
============================================
Files 2436 2687 +251
Lines 133233 147785 +14552
Branches 20636 22648 +2012
============================================
+ Hits 82274 94639 +12365
- Misses 44911 46210 +1299
- Partials 6048 6936 +888
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Jackie-Jiang
approved these changes
Dec 15, 2024
Contributor
Jackie-Jiang
left a comment
Jackie-Jiang
left a comment
There was a problem hiding this comment.
In PostgreSQL, now() returns timestamp with time zone, so I believe this is the correct change
zeronerdzerogeekzerocool
pushed a commit
to zeronerdzerogeekzerocool/pinot
that referenced
this pull request
Feb 20, 2025
yashmayya
added
the
backward-incompat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOWscalar function returns a value ofLONGtype representing milliseconds since epoch. It was added before theTIMESTAMPdata type was introduced to Pinot.TIMESTAMPADDtakes a datetime type as its third parameter (ex -TIMESTAMPADD(day, 10, CAST('2024-12-01' AS TIMESTAMP)).TIMESTAMPADD(day, 10, now())(LONG/TIMESTAMPare interchangeable in v1 which is not strongly typed) works fine but it fails in the v2 engine with an error like -Cannot apply 'TIMESTAMPADD' to arguments of type 'TIMESTAMPADD(<INTERVAL DAY>, <INTEGER>, <BIGINT>)'. Supported form(s): 'TIMESTAMPADD(<ANY>, <INTEGER>, <DATETIME>)'.FROM_DATE_TIME, we can add an override to the operator table to make sure that the return type for theNOWscalar function is defined asTIMESTAMPand it can be used as one (in terms of execution in the query engine,TIMESTAMPis represented asLONGinternally so that isn't an issue here).