Fix the query option override for leaf stage #14603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangfu0
approved these changes
Dec 5, 2024
xiangfu0
approved these changes
Dec 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14603 +/- ##
============================================
+ Coverage 61.75% 64.04% +2.29%
- Complexity 207 1572 +1365
============================================
Files 2436 2687 +251
Lines 133233 147683 +14450
Branches 20636 22632 +1996
============================================
+ Hits 82274 94589 +12315
- Misses 44911 46164 +1253
- Partials 6048 6930 +882
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
davecromberge
pushed a commit
to davecromberge/pinot
that referenced
this pull request
Dec 10, 2024
zeronerdzerogeekzerocool
pushed a commit
to zeronerdzerogeekzerocool/pinot
that referenced
this pull request
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the bug of query option being completely overridden when generating leaf stage query. During query planning, we might add query options (e.g.
serverReturnFinalResult), which should be preserved.