[Multi-stage] Allow filter for lookup JOIN #14523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackie-Jiang
force-pushed
the
allow_filter_in_lookup_join
branch
from
3cf68fa to
de41d59
Compare
Jackie-Jiang
force-pushed
the
allow_filter_in_lookup_join
branch
from
de41d59 to
4652829
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14523 +/- ##
============================================
+ Coverage 61.75% 63.94% +2.19%
- Complexity 207 1569 +1362
============================================
Files 2436 2675 +239
Lines 133233 146975 +13742
Branches 20636 22559 +1923
============================================
+ Hits 82274 93981 +11707
- Misses 44911 46063 +1152
- Partials 6048 6931 +883
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
gortiz
reviewed
Nov 25, 2024
Comment on lines
+100
to
+107
| RelOptUtil.classifyFilters(join, | ||
| aboveFilters, | ||
| joinType.canPushIntoFromAbove(), | ||
| joinType.canPushLeftFromAbove(), | ||
| canPushRight && joinType.canPushRightFromAbove(), | ||
| joinFilters, | ||
| leftFilters, | ||
| rightFilters); |
Contributor
There was a problem hiding this comment.
Probably we can contribute a patch in Calcite where FilterJoinRule calls an instance method to do this so we could just extend it.
Something like:
public class FilterJoinRule extends ... {
boolean classifyFilters(
RelNode joinRel,
List<RexNode> filters,
JoinRelType relType,
List<RexNode> joinFilters,
List<RexNode> leftFilters,
List<RexNode> rightFilters) {
RelOptUtil.classifyFilters(join,
aboveFilters,
joinType.canPushIntoFromAbove(),
joinType.canPushLeftFromAbove(),
joinType.canPushRightFromAbove(),
joinFilters,
leftFilters,
rightFilters);
}
}So we could simplify this class by overriding that method and adding there our check.
gortiz
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customize the following 2 rules to not push down filters/transforms for lookup JOIN:
CoreRules.FILTER_INTO_JOINandCoreRules.JOIN_CONDITION_PUSH: Do not push down filter to right table, but allow pushing down to left tableCoreRules.PROJECT_JOIN_TRANSPOSE: Disable the rule for lookup JOINTODO: Allow transpose to left table in
CoreRules.PROJECT_JOIN_TRANSPOSE