Add TLS support to mailboxes used in the multi-stage engine #14476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashmayya
added
security
multi-stage
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14476 +/- ##
============================================
+ Coverage 61.75% 63.81% +2.06%
- Complexity 207 1567 +1360
============================================
Files 2436 2663 +227
Lines 133233 146225 +12992
Branches 20636 22404 +1768
============================================
+ Hits 82274 93313 +11039
- Misses 44911 46022 +1111
- Partials 6048 6890 +842
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yashmayya
commented
Nov 19, 2024
| channelBuilder = | ||
| ManagedChannelBuilder.forAddress(host, port).maxInboundMessageSize(config.getMaxInboundMessageSizeBytes()) | ||
| .usePlaintext(); | ||
| channelBuilder = ManagedChannelBuilder |
Contributor
Author
There was a problem hiding this comment.
Only refactors in this file.
| if (tlsConfig != null) { | ||
| try { | ||
| _server = NettyServerBuilder.forPort(port).sslContext(buildGRpcSslContext(tlsConfig)) | ||
| _server = NettyServerBuilder.forPort(port).sslContext(buildGrpcSslContext(tlsConfig)) |
Contributor
Author
There was a problem hiding this comment.
Only refactors in this file.
gortiz
approved these changes
Nov 19, 2024
davecromberge
pushed a commit
to davecromberge/pinot
that referenced
this pull request
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pinot.multistage.engine.tls.enabledis set totrue. The mailbox mechanism is also used to stream the final query results from servers to brokers.