Fix window frame upper bound offset extraction in PinotWindowExchangeNodeInsertRule #14304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashmayya
force-pushed
the
fix-window-frame-upper-bound-extraction
branch
from
23db8c4 to
78d8039
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14304 +/- ##
============================================
+ Coverage 61.75% 63.73% +1.98%
- Complexity 207 1555 +1348
============================================
Files 2436 2659 +223
Lines 133233 145452 +12219
Branches 20636 22219 +1583
============================================
+ Hits 82274 92704 +10430
- Misses 44911 45892 +981
- Partials 6048 6856 +808
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Jackie-Jiang
approved these changes
Oct 27, 2024
yashmayya
added
the
window-functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PinotWindowExchangeNodeInsertRule(from changes recently merged in Add support for defining custom window frame bounds for window functions #14273).